Page MenuHomeSolus

Update bash to 5.0.16

Authored by ZVNexus on Feb 8 2020, 4:11 AM.


Group Reviewers
Triage Team

Bash 11 -> 16 fixes:

When using previous-history to go back beyond the beginning of the history list,
it's possible to move to an incorrect partial line.

Reading history entries with timestamps can result in history entries joined
by linefeeds.

If the current line is empty, using the emacs C-xC-e binding to enter the
editor will edit the previous command instead of the current (empty) one.

If alias expansion is enabled when processing the command argument to the
`-c' option, an alias is defined in that command, and the command ends with
the invocation of that alias, the shell's command parser can prematurely
terminate before the entire command is executed.

Bash waits too long to reap /dev/fd process substitutions used as redirections
with loops and group commands, which can lead to file descriptor exhaustion.

Test Plan

Rebooted and checked if system didn't blow up, (it didn't) bashrc loaded fine.
I tested WoeUSB which is a bash script and it completely the task succesfully.

Diff Detail

R420 bash
No Linters Available
No Unit Test Coverage

Event Timeline

ZVNexus created this revision.Feb 8 2020, 4:11 AM
ZVNexus requested review of this revision.Feb 8 2020, 4:11 AM
DataDrake requested changes to this revision.Feb 8 2020, 4:47 PM
DataDrake added a subscriber: DataDrake.

Can you provide a listing of bug-fixes rather than just a version change in the Summary please?

As far as the Test Plan goes, I don't see the point in just copying the output of bash --version. Please remember that the Summary and Test Plan are presented directly to a user in the Changelog tab of a package in the Software Center. I'd like to see more meaningful tests with how much this can break the universe if it isn't working right. At a minimum, I'd like to know that the system boots and what scripts were run for additional testing (emphasis on scripts from the Solus repo and not personal ones).

This revision now requires changes to proceed.Feb 8 2020, 4:47 PM

Would testing WoeUSB count as a valid test for this, its a bash script and I just updated it to the latest version earlier and tested it was working without problems. Or are there any particular tests you want run, I made sure system didn't explode after a reboot, bashrc was loaded and everything seemed to be fine.

ZVNexus updated this revision to Diff 19661.Feb 8 2020, 8:00 PM

Better summary & tests

ZVNexus edited the summary of this revision. (Show Details)Feb 8 2020, 8:01 PM
ZVNexus edited the test plan for this revision. (Show Details)
JoshStrobl requested changes to this revision.Feb 14 2020, 3:34 AM
JoshStrobl added a subscriber: JoshStrobl.

80 column is the devil. Don't enforce a column limit or hard lines. This is the 21st century.

This revision now requires changes to proceed.Feb 14 2020, 3:34 AM
ZVNexus abandoned this revision.EditedFeb 15 2020, 11:39 PM

I don't recall intentionally doing that, I didn't even know 80 column was a thing, or limits to columns or hardlines D:
Anyways I don't have Linux installed right now so if someone wants to take this over or start a new patch please do.