Pass "open" to "button.lid_init_state"
AbandonedPublic
Actions

Authored by ZVNexus on Feb 8 2020, 2:49 AM.

Details

Reviewers

Summary

When this option is specified, the ACPI button driver always reports the
initial lid state as "opened" and whether the "opened"/"closed" events
are paired fully relies on the firmware implementation.

This may fix some platforms where the returning value of the _LID
control method is not reliable and the initial lid state notification is
missing.

Test Plan

Razer Blade Stealth no longer has an issue with suspend loop after sleep.

Diff Detail

Repository

R3571 linux-current

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ZVNexus requested review of this revision.Feb 8 2020, 2:49 AM

ZVNexus created this revision.

This is also a patch in linux-lts.
https://dev.getsol.us/source/linux-lts/browse/master/files/acpi/1-2-ACPI-button-Change-default-behavior-to-lid_init_state-open.patch

ZVNexus added a comment.Feb 8 2020, 4:45 AM

This comment was removed by ZVNexus.

I'm not adding another cmdline option for a device specific fix. The only reason we have the radeon/amdgpu ones is for everthing to play nice across all AMD GPUs.

Revision Contents
Changeset List

Path

Size

files/

cmdline

2 lines

Diff 19649

View Options

Pass "open" to "button.lid_init_state"AbandonedPublicActions