Page MenuHomeSolus

Initial inclusion of python-typing-extensions
ClosedPublic

Authored by algent on Feb 6 2020, 10:05 PM.
Tags
None
Referenced Files
F11020633: D8187.diff
Mon, Aug 7, 7:28 AM
F10807313: D8187.id19620.diff
May 30 2023, 4:31 AM
F10806810: D8187.diff
May 30 2023, 2:37 AM
F10806662: D8187.id19829.diff
May 30 2023, 2:00 AM
F10773317: D8187.id.diff
May 21 2023, 8:07 PM
F10708556: D8187.id.diff
Apr 27 2023, 5:26 PM
Subscribers

Details

Summary

This is needed as rundependency for python-mypy

Signed-off-by: Algent Albrahimi <algent@protonmail.com>

Test Plan

Run python-mypy and check for errors for a few python scripts

Diff Detail

Repository
R4911 python-typing-extensions
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

We're now on python 3.7. Is this still needed? Really don't want to accept a backport for a python version we already have.

Hey @joebonrichie! While testing python-mypy i run into this error:

Traceback (most recent call last):
  File "/usr/bin/mypy", line 6, in <module>
    from pkg_resources import load_entry_point
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 3250, in <module>
    @_call_aside
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 3234, in _call_aside
    f(*args, **kwargs)
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 3263, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 583, in _build_master
    ws.require(__requires__)
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 900, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 786, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'typing_extensions>=3.7.4' distribution was not found and is required by mypy

In python-mypy v760 changelog
They state:

Recommend typing_extensions instead of mypy_extensions for TypedDict (PR 8023)

This is their PR.

typing-extensions is a module of python-typing. Not sure if I should add python-typing as rundep for this package.

Had a further look, looks like it needs python 3.8 to make use of the stdlib typing-extensions due to it's TypedDict usage. Seems good to me.

This revision is now accepted and ready to land.Feb 7 2020, 6:48 PM
This revision was automatically updated to reflect the committed changes.