Page MenuHomeSolus

Initial commit of sysprof
ClosedPublic

Authored by serebit on Feb 6 2020, 12:47 AM.

Details

Summary

Inclusion of sysprof fixes T8689.

Test Plan

Run a quick full-system profile using the GTK frontend

Diff Detail

Repository
R4938 sysprof
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

serebit created this revision.Feb 6 2020, 12:47 AM
serebit requested review of this revision.Feb 6 2020, 12:47 AM
DataDrake requested changes to this revision.Feb 6 2020, 5:44 PM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
13

pkgconfigs go first

pspec_x86_64.xml
169

Disable static libs

This revision now requires changes to proceed.Feb 6 2020, 5:44 PM
serebit added inline comments.Feb 8 2020, 7:42 PM
pspec_x86_64.xml
169

How do I do that with meson, exactly? I looked around, but couldn't find anything that worked.

should be --disable-static

should be --disable-static

I did try that, but it seems Meson doesn't support that argument.

rm would be a solution as well

serebit updated this revision to Diff 19667.Feb 8 2020, 10:40 PM

Removed static lib, changed order of build deps

serebit marked an inline comment as done.Feb 8 2020, 10:40 PM
JoshStrobl requested changes to this revision.Feb 19 2020, 8:35 AM
JoshStrobl added a subscriber: JoshStrobl.

You could try patching https://gitlab.gnome.org/GNOME/sysprof/blob/master/src/libsysprof-capture/meson.build#L44 instead to use shared_library rather than static_library

This revision now requires changes to proceed.Feb 19 2020, 8:35 AM
serebit added a comment.EditedFeb 22 2020, 12:35 AM

You could try patching https://gitlab.gnome.org/GNOME/sysprof/blob/master/src/libsysprof-capture/meson.build#L44 instead to use shared_library rather than static_library

Gave that a shot. After spending an hour or so attempting to get the build to work without libsysprof-capture (and consulting someone who knows meson far better than I), I've come to the conclusion that rm-ing it is our best course of action within my power. If someone more well versed in meson wants to give this a try, be my guest.

Understood, let's get this updated to the 3.36.0 release and land it then ๐Ÿ‘

Understood, let's get this updated to the 3.36.0 release and land it then ๐Ÿ‘

You got it. Bumping now.

serebit updated this revision to Diff 20643.Wed, Apr 8, 4:06 PM
serebit marked an inline comment as done.

Update to 3.36.0

JoshStrobl accepted this revision.Wed, Apr 8, 4:09 PM

LGTM, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Apr 8, 4:10 PM
Closed by commit R4938:334d097dfdab: Initial commit of sysprof (authored by serebit, committed by JoshStrobl). ยท Explain Why
This revision was automatically updated to reflect the committed changes.