Page MenuHomeSolus

Initial commit of sysprof
Needs RevisionPublic

Authored by serebit on Thu, Feb 6, 12:47 AM.

Details

Reviewers
DataDrake
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T8689: Request: sysprof
Summary

Inclusion of sysprof fixes T8689.

Test Plan

Run a quick full-system profile using the GTK frontend

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

serebit created this revision.Thu, Feb 6, 12:47 AM
serebit requested review of this revision.Thu, Feb 6, 12:47 AM
DataDrake requested changes to this revision.Thu, Feb 6, 5:44 PM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
13

pkgconfigs go first

pspec_x86_64.xml
169

Disable static libs

This revision now requires changes to proceed.Thu, Feb 6, 5:44 PM
serebit added inline comments.Sat, Feb 8, 7:42 PM
pspec_x86_64.xml
169

How do I do that with meson, exactly? I looked around, but couldn't find anything that worked.

should be --disable-static

should be --disable-static

I did try that, but it seems Meson doesn't support that argument.

rm would be a solution as well

serebit updated this revision to Diff 19667.Sat, Feb 8, 10:40 PM

Removed static lib, changed order of build deps

serebit marked an inline comment as done.Sat, Feb 8, 10:40 PM
JoshStrobl requested changes to this revision.Wed, Feb 19, 8:35 AM
JoshStrobl added a subscriber: JoshStrobl.

You could try patching https://gitlab.gnome.org/GNOME/sysprof/blob/master/src/libsysprof-capture/meson.build#L44 instead to use shared_library rather than static_library

This revision now requires changes to proceed.Wed, Feb 19, 8:35 AM