Page MenuHomeSolus

Initial commit of sysprof
ClosedPublic

Authored by serebit on Feb 6 2020, 12:47 AM.
Tags
None
Referenced Files
F10985609: D8180.diff
Sun, Jul 23, 10:10 PM
F10984572: D8180.id20643.diff
Sun, Jul 23, 6:17 PM
F10912300: D8180.id19593.diff
Jul 7 2023, 2:45 PM
F10857372: D8180.id19593.diff
Jun 15 2023, 4:33 AM
F10851056: D8180.id20643.diff
Jun 12 2023, 9:02 AM
F10848962: D8180.id19667.diff
Jun 11 2023, 5:22 PM
F10834303: D8180.diff
Jun 7 2023, 9:50 AM
F10772725: D8180.id19667.diff
May 21 2023, 2:30 PM

Details

Summary

Inclusion of sysprof fixes T8689.

Test Plan

Run a quick full-system profile using the GTK frontend

Diff Detail

Repository
R4938 sysprof
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
13

pkgconfigs go first

pspec_x86_64.xml
169

Disable static libs

This revision now requires changes to proceed.Feb 6 2020, 5:44 PM
pspec_x86_64.xml
169

How do I do that with meson, exactly? I looked around, but couldn't find anything that worked.

should be --disable-static

I did try that, but it seems Meson doesn't support that argument.

Removed static lib, changed order of build deps

JoshStrobl added a subscriber: JoshStrobl.

You could try patching https://gitlab.gnome.org/GNOME/sysprof/blob/master/src/libsysprof-capture/meson.build#L44 instead to use shared_library rather than static_library

This revision now requires changes to proceed.Feb 19 2020, 8:35 AM

You could try patching https://gitlab.gnome.org/GNOME/sysprof/blob/master/src/libsysprof-capture/meson.build#L44 instead to use shared_library rather than static_library

Gave that a shot. After spending an hour or so attempting to get the build to work without libsysprof-capture (and consulting someone who knows meson far better than I), I've come to the conclusion that rm-ing it is our best course of action within my power. If someone more well versed in meson wants to give this a try, be my guest.

Understood, let's get this updated to the 3.36.0 release and land it then 👍

Understood, let's get this updated to the 3.36.0 release and land it then 👍

You got it. Bumping now.

serebit marked an inline comment as done.

Update to 3.36.0

This revision was not accepted when it landed; it landed in state Needs Review.Apr 8 2020, 4:10 PM
Closed by commit R4938:334d097dfdab: Initial commit of sysprof (authored by serebit, committed by JoshStrobl). · Explain Why
This revision was automatically updated to reflect the committed changes.