Page MenuHomeSolus

Initial inclusion of mininet
Needs ReviewPublic

Authored by Tzigamm on Feb 4 2020, 5:02 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T8469: Mininet
Summary

Initial inclusion of mininet, resolves T8469

Test Plan

Start ovsdb-server.service and start the 'mn' command as root

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Tzigamm created this revision.Feb 4 2020, 5:02 PM
Tzigamm requested review of this revision.Feb 4 2020, 5:02 PM
DataDrake requested changes to this revision.Feb 5 2020, 1:49 PM
DataDrake added a subscriber: DataDrake.

Is there any reason this can't be Python 3?

package.yml
12

These should be alphabetical with pkgconfigs first.

13

This should use a pkgconfig()

This revision now requires changes to proceed.Feb 5 2020, 1:49 PM
Tzigamm updated this revision to Diff 19683.Feb 10 2020, 2:47 PM
Tzigamm marked 2 inline comments as done.

Fix the mistakes pointed out by DD

Tzigamm updated this revision to Diff 19684.Feb 10 2020, 3:01 PM

Remove unused dependency, thanks joebonrichie

DataDrake requested changes to this revision.Feb 19 2020, 1:27 PM

You're going to need to squash your git history because this needs to apply against an empty repo.

This revision now requires changes to proceed.Feb 19 2020, 1:27 PM
Tzigamm updated this revision to Diff 19870.Feb 19 2020, 4:49 PM

Squashed everything together

DataDrake requested changes to this revision.Feb 23 2020, 1:30 PM
DataDrake added inline comments.
package.yml
5

Should follow the normal link format, not the resolved link when downloading:

https://github.com/mininet/mininet/archive/2.2.2.tar.gz

This revision now requires changes to proceed.Feb 23 2020, 1:30 PM
Tzigamm updated this revision to Diff 19983.Feb 25 2020, 9:53 AM
Tzigamm marked an inline comment as done.

Changed the source link