Page MenuHomeSolus
Differential D8174

Initial inclusion of mininet
ClosedPublic
Actions

Authored by Tzigamm on Feb 4 2020, 5:02 PM.
Tags
None
Referenced Files
F11023779: D8174.diff
Tue, Aug 8, 4:26 PM
F10891512: D8174.diff
Jun 29 2023, 3:55 AM
F10831178: D8174.id.diff
Jun 5 2023, 7:54 AM
F10829278: D8174.id19870.diff
Jun 4 2023, 11:40 AM
F10828838: D8174.id19557.diff
Jun 4 2023, 10:30 AM
F10828489: D8174.id19683.diff
Jun 4 2023, 9:34 AM
F10828274: D8174.id19983.diff
Jun 4 2023, 8:56 AM
F10828267: D8174.id20770.diff
Jun 4 2023, 8:54 AM
View All 22 Files
Subscribers
DataDrake

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T8469: Mininet
Commits
R4915:d61588e4b597: Initial inclusion of mininet
Summary

Initial inclusion of mininet, resolves T8469

Test Plan

Start ovsdb-server.service and start the 'mn' command as root

Diff Detail

Repository
R4915 mininet
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Tzigamm created this revision.Feb 4 2020, 5:02 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptFeb 4 2020, 5:02 PM
Tzigamm requested review of this revision.Feb 4 2020, 5:02 PM
DataDrake requested changes to this revision.Feb 5 2020, 1:49 PM
DataDrake added a subscriber: DataDrake.

Is there any reason this can't be Python 3?

package.yml
12

These should be alphabetical with pkgconfigs first.

13

This should use a pkgconfig()

This revision now requires changes to proceed.Feb 5 2020, 1:49 PM
Tzigamm updated this revision to Diff 19683.Feb 10 2020, 2:47 PM
Tzigamm marked 2 inline comments as done.

Fix the mistakes pointed out by DD

Tzigamm updated this revision to Diff 19684.Feb 10 2020, 3:01 PM

Remove unused dependency, thanks joebonrichie

DataDrake requested changes to this revision.Feb 19 2020, 1:27 PM

You're going to need to squash your git history because this needs to apply against an empty repo.

This revision now requires changes to proceed.Feb 19 2020, 1:27 PM
Tzigamm updated this revision to Diff 19870.Feb 19 2020, 4:49 PM

Squashed everything together

DataDrake requested changes to this revision.Feb 23 2020, 1:30 PM
DataDrake added inline comments.
package.yml
6

Should follow the normal link format, not the resolved link when downloading:

https://github.com/mininet/mininet/archive/2.2.2.tar.gz

This revision now requires changes to proceed.Feb 23 2020, 1:30 PM
Tzigamm updated this revision to Diff 19983.Feb 25 2020, 9:53 AM
Tzigamm marked an inline comment as done.

Changed the source link

DataDrake accepted this revision.Apr 13 2020, 2:34 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Apr 13 2020, 2:34 AM
Closed by commit R4915:d61588e4b597: Initial inclusion of mininet (authored by Tzigamm, committed by DataDrake). · Explain WhyApr 13 2020, 2:35 AM
This revision was automatically updated to reflect the committed changes.
DataDrake added a commit: R4915:d61588e4b597: Initial inclusion of mininet.

Revision Contents
Changeset List

PathSize
1 line
1 line
files/
13 lines
33 lines
192 lines

Diff 20770

View Options

Makefile

Loading...
View Options

abi_used_libs

Loading...
View Options

files/fix-build-dirs.patch

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.