Page MenuHomeSolus
Differential D8173

Initial inclusion of openvswitch, needed by mininet
ClosedPublic
Actions

Authored by Tzigamm on Feb 4 2020, 4:59 PM.
Tags
None
Referenced Files
F11010606: D8173.id19681.diff
Thu, Aug 3, 6:05 AM
F11002287: D8173.diff
Mon, Jul 31, 12:36 AM
F10989379: D8173.id19556.diff
Mon, Jul 24, 3:00 PM
F10944056: D8173.id19943.diff
Fri, Jul 14, 10:02 PM
F10943991: D8173.diff
Fri, Jul 14, 10:01 PM
F10896990: D8173.id19682.diff
Jul 2 2023, 3:37 AM
F10874762: D8173.id19680.diff
Jun 20 2023, 2:00 AM
F10874759: D8173.id19682.diff
Jun 20 2023, 2:00 AM
View All 32 Files
Subscribers
DataDrake
facocalj

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T8469: Mininet
Commits
R4914:5a108e9ac234: Initial inclusion of openvswitch, needed by mininet
Test Plan

Start mininet (5.5 kernel required)

Diff Detail

Repository
R4914 openvswitch
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Tzigamm created this revision.Feb 4 2020, 4:59 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptFeb 4 2020, 4:59 PM
Tzigamm requested review of this revision.Feb 4 2020, 4:59 PM
Tzigamm added a task: T8469: Mininet.Feb 4 2020, 4:59 PM
DataDrake retitled this revision from Summary: Initial inclusion of openvswitch, needed by mininet to Initial inclusion of openvswitch, needed by mininet.Feb 5 2020, 1:49 PM
DataDrake requested changes to this revision.Feb 5 2020, 1:54 PM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
12

Alphabetize

15

use a pkgconfig

17

Shouldn't this be a rundep too?

18

alphabetize

25

Remove blank lines

31

Quotes aren't necessary

pspec_x86_64.xml
23

These should be in /usr/share/bash-completion/completions/ without the .bash extentsion.

25

Remove empty directory

260

Disable static libs with configure if possible, otherwise manually remove in the install phase.

This revision now requires changes to proceed.Feb 5 2020, 1:54 PM
Tzigamm updated this revision to Diff 19680.Feb 10 2020, 12:26 PM
Tzigamm marked 9 inline comments as done.

Fix the mistakes pointed out by DD

Tzigamm updated this revision to Diff 19681.Feb 10 2020, 2:44 PM

Fix the mistakes pointed out by DD

Tzigamm added a comment.Feb 10 2020, 2:45 PM

Urg, my bad, pushed to the wrong diff

Tzigamm updated this revision to Diff 19682.Feb 10 2020, 2:46 PM

Fix the mistakes pointed out by DD

DataDrake requested changes to this revision.Feb 19 2020, 1:26 PM

You're going to need to squash your git history because this needs to apply against an empty repo, not your last diff.

This revision now requires changes to proceed.Feb 19 2020, 1:26 PM
Tzigamm updated this revision to Diff 19871.Feb 19 2020, 4:54 PM

Squashed everything together

DataDrake accepted this revision.Feb 23 2020, 1:28 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Feb 23 2020, 1:28 PM
Closed by commit R4914:5a108e9ac234: Initial inclusion of openvswitch, needed by mininet (authored by Tzigamm, committed by DataDrake). · Explain WhyFeb 23 2020, 1:28 PM
This revision was automatically updated to reflect the committed changes.
DataDrake added a commit: R4914:5a108e9ac234: Initial inclusion of openvswitch, needed by mininet.
facocalj added a subscriber: facocalj.Apr 17 2020, 9:55 AM
This comment was removed by facocalj.

Revision Contents
Changeset List

PathSize
1 line
9086 lines
7 lines
files/
15 lines
7 lines
35 lines
277 lines

Diff 19943

View Options

Makefile

Loading...
View Options

abi_symbols

Loading...
View Options

abi_used_libs

Loading...
View Options

files/ovs-vswitchd.service

Loading...
View Options

files/ovsdb-server.service

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.