Page MenuHomeSolus

Initial inclusion of openvswitch, needed by mininet
ClosedPublic

Authored by Tzigamm on Feb 4 2020, 4:59 PM.

Details

Test Plan

Start mininet (5.5 kernel required)

Diff Detail

Repository
R4914 openvswitch
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Tzigamm created this revision.Feb 4 2020, 4:59 PM
Tzigamm requested review of this revision.Feb 4 2020, 4:59 PM
DataDrake retitled this revision from Summary: Initial inclusion of openvswitch, needed by mininet to Initial inclusion of openvswitch, needed by mininet.Feb 5 2020, 1:49 PM
DataDrake requested changes to this revision.Feb 5 2020, 1:54 PM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
package.yml
12

Alphabetize

15

use a pkgconfig

17

Shouldn't this be a rundep too?

18

alphabetize

25

Remove blank lines

31

Quotes aren't necessary

pspec_x86_64.xml
23

These should be in /usr/share/bash-completion/completions/ without the .bash extentsion.

25

Remove empty directory

260

Disable static libs with configure if possible, otherwise manually remove in the install phase.

This revision now requires changes to proceed.Feb 5 2020, 1:54 PM
Tzigamm updated this revision to Diff 19680.Feb 10 2020, 12:26 PM
Tzigamm marked 9 inline comments as done.

Fix the mistakes pointed out by DD

Tzigamm updated this revision to Diff 19681.Feb 10 2020, 2:44 PM

Fix the mistakes pointed out by DD

Urg, my bad, pushed to the wrong diff

Tzigamm updated this revision to Diff 19682.Feb 10 2020, 2:46 PM

Fix the mistakes pointed out by DD

DataDrake requested changes to this revision.Feb 19 2020, 1:26 PM

You're going to need to squash your git history because this needs to apply against an empty repo, not your last diff.

This revision now requires changes to proceed.Feb 19 2020, 1:26 PM
Tzigamm updated this revision to Diff 19871.Feb 19 2020, 4:54 PM

Squashed everything together

DataDrake accepted this revision.Feb 23 2020, 1:28 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Feb 23 2020, 1:28 PM
This revision was automatically updated to reflect the committed changes.
This comment was removed by facocalj.