Page MenuHomeSolus
Differential D8161

Initial inclusion of patchelf
ClosedPublic
Actions

Authored by tomocafe on Feb 2 2020, 5:37 PM.
Tags
None
Referenced Files
F10875827: D8161.diff
Jun 20 2023, 7:41 AM
F10846537: D8161.diff
Jun 11 2023, 5:24 AM
F10846525: D8161.id.diff
Jun 11 2023, 5:18 AM
F10817696: D8161.id19536.diff
Jun 1 2023, 9:01 AM
F10817622: D8161.id19536.diff
Jun 1 2023, 8:21 AM
F10817591: D8161.id19536.diff
Jun 1 2023, 8:08 AM
F10808502: D8161.id19540.diff
May 30 2023, 8:59 AM
F10807785: D8161.id19537.diff
May 30 2023, 6:07 AM
View All 14 Files
Subscribers
DataDrake
Girtablulu
Jacalz

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T8660: patchelf
Commits
R4955:9892f3849b2e: Initial inclusion of patchelf
Summary

Initial inclusion of patchelf. Resolves T8660.

Test Plan

Change the rpath of a binary

Diff Detail

Repository
R4955 patchelf
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomocafe created this revision.Feb 2 2020, 5:37 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptFeb 2 2020, 5:37 PM
tomocafe requested review of this revision.Feb 2 2020, 5:37 PM
tomocafe updated this revision to Diff 19537.Feb 2 2020, 5:42 PM

Fix commit messages

Girtablulu requested changes to this revision.Feb 2 2020, 5:42 PM
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
9

should be below the source

13

shouldn't be on a new line

18

comes to the end

pspec_x86_64.xml
27

This can be removed

This revision now requires changes to proceed.Feb 2 2020, 5:42 PM
Girtablulu added a comment.Feb 2 2020, 5:42 PM

and please a proper test, check while building is not enough

Jacalz added a subscriber: Jacalz.Feb 2 2020, 5:53 PM
Jacalz added inline comments.
package.yml
9

Please always use https:// over http:// when it is supported.

tomocafe updated this revision to Diff 19539.Feb 2 2020, 6:19 PM
tomocafe marked 4 inline comments as done.

package.yml fixes

tomocafe updated this revision to Diff 19540.Feb 2 2020, 6:47 PM
tomocafe retitled this revision from Initial inclusion of patchelf. Resolves T8660. to Initial inclusion of patchelf.
tomocafe edited the summary of this revision. (Show Details)
tomocafe edited the test plan for this revision. (Show Details)
tomocafe added a task: T8660: patchelf.

Properly remove unneeded docs

tomocafe marked an inline comment as done.Feb 16 2020, 11:29 PM

This one is ready for review, all feedback thus far has been addressed. Thanks!

package.yml
9

Done, also asked upstream to fix it on their docs. Copy pasted from them ?

https://github.com/NixOS/patchelf/issues/191

DataDrake accepted this revision.Apr 13 2020, 2:43 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

DataDrake removed a reviewer: Girtablulu.Apr 13 2020, 2:44 AM
This revision is now accepted and ready to land.Apr 13 2020, 2:44 AM
Closed by commit R4955:9892f3849b2e: Initial inclusion of patchelf (authored by tomocafe, committed by DataDrake). · Explain WhyApr 13 2020, 2:45 AM
This revision was automatically updated to reflect the committed changes.
DataDrake added a commit: R4955:9892f3849b2e: Initial inclusion of patchelf.

Revision Contents
Changeset List

PathSize
1 line
3 lines
20 lines
36 lines

Diff 20771

View Options

Makefile

Loading...
View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.