Page MenuHomeSolus

Initial inclusion of patchelf
ClosedPublic

Authored by tomocafe on Feb 2 2020, 5:37 PM.

Details

Summary

Initial inclusion of patchelf. Resolves T8660.

Test Plan

Change the rpath of a binary

Diff Detail

Repository
R4955 patchelf
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tomocafe created this revision.Feb 2 2020, 5:37 PM
tomocafe requested review of this revision.Feb 2 2020, 5:37 PM
tomocafe updated this revision to Diff 19537.Feb 2 2020, 5:42 PM

Fix commit messages

Girtablulu requested changes to this revision.Feb 2 2020, 5:42 PM
Girtablulu added a subscriber: Girtablulu.
Girtablulu added inline comments.
package.yml
9

should be below the source

13

shouldn't be on a new line

18

comes to the end

pspec_x86_64.xml
27

This can be removed

This revision now requires changes to proceed.Feb 2 2020, 5:42 PM

and please a proper test, check while building is not enough

Jacalz added a subscriber: Jacalz.Feb 2 2020, 5:53 PM
Jacalz added inline comments.
package.yml
9

Please always use https:// over http:// when it is supported.

tomocafe updated this revision to Diff 19539.Feb 2 2020, 6:19 PM
tomocafe marked 4 inline comments as done.

package.yml fixes

tomocafe updated this revision to Diff 19540.Feb 2 2020, 6:47 PM
tomocafe retitled this revision from Initial inclusion of patchelf. Resolves T8660. to Initial inclusion of patchelf.
tomocafe edited the summary of this revision. (Show Details)
tomocafe edited the test plan for this revision. (Show Details)
tomocafe added a task: T8660: patchelf.

Properly remove unneeded docs

tomocafe marked an inline comment as done.Feb 16 2020, 11:29 PM

This one is ready for review, all feedback thus far has been addressed. Thanks!

package.yml
9

Done, also asked upstream to fix it on their docs. Copy pasted from them ๐Ÿ˜œ

https://github.com/NixOS/patchelf/issues/191

DataDrake accepted this revision.Apr 13 2020, 2:43 AM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Apr 13 2020, 2:44 AM
This revision was automatically updated to reflect the committed changes.