Initial commit of QMMP
Details
Details
Diff Detail
Diff Detail
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
A TEST PLAN is a little verification that the package is correct and functioning. Example: You build a pdf reader that it's inclusion was ACCEPTED, packaged it, tested locally and then You write in the TEST PLAN something like: "Opened a pdf and saw its contents".
In your current case you might need to put: "Played some audio tracks successfully".
Comment Actions
@melosaiyan I've forgot to mention something important: When You upload a diff that solves a package request You need to mention in the summary that the inclusion of the package fixes it. E.g.:
Initial commit of tarantula The inclusion of tarantula fixes TXXXX Signed-off-by: Your Name <your@email.com>
In your case it would be:
Initial Commit of QMMP The inclusion of qmmp fixes T5356 Signed-off-by: Brian Urbina <brian.urbina@outlook.com>
P.S.: You have to make some modifications in your package.yml.
| package.yml | ||
|---|---|---|
| 7 | Should be GPL-2.0-or-later. | |
| 12 | The order of the dependencies should be in alphabetical order like this: - pkgconfig(libexample) - pkgconfig32(libexample) - example-tools Search for package duplicates like pkgconfig(flac) pkgconfig(flac++) Also the indentation is not 8 spaces, it's 4 spaces | |
Comment Actions
@YakoYakoYokuYoku Thank you so much for your help! I finally got around to making additional changes. Hopefully I included all the necessary changes for review.
Comment Actions
@melosaiyan The correct place to mention that it "Fixes TNNN" is in the summary. You don't need to have it in the commit message.
| package.yml | ||
|---|---|---|
| 11 | Please make sure that you aren't listing any pkgconfigs that are dependencies of the ones already listed. | |
| pspec_x86_64.xml | ||
| 8 | You changed it in the pacakge.yml, but a rebuild is needed to fix it in the pspec. | |