Page MenuHomeSolus

Initial Commit of QMMP Added correct GPL license info and the inclusion of qmmp fixes T5356
AbandonedPublic

Authored by melosaiyan on Jan 31 2020, 8:10 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Summary

Initial commit of QMMP

Test Plan

Played some audio tracks successfully

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

melosaiyan created this revision.Jan 31 2020, 8:10 PM
melosaiyan requested review of this revision.Jan 31 2020, 8:10 PM
melosaiyan updated this revision to Diff 19494.Jan 31 2020, 8:14 PM
melosaiyan edited the test plan for this revision. (Show Details)

Initial commit of QMMP

A TEST PLAN is a little verification that the package is correct and functioning. Example: You build a pdf reader that it's inclusion was ACCEPTED, packaged it, tested locally and then You write in the TEST PLAN something like: "Opened a pdf and saw its contents".

In your current case you might need to put: "Played some audio tracks successfully".

melosaiyan updated this revision to Diff 19495.Jan 31 2020, 8:58 PM
melosaiyan edited the test plan for this revision. (Show Details)

Adding a test plan that confirms functionality of application

Thanks again @YakoYakoYokuYoku! I made the update.

@melosaiyan I've forgot to mention something important: When You upload a diff that solves a package request You need to mention in the summary that the inclusion of the package fixes it. E.g.:

Initial commit of tarantula

The inclusion of tarantula fixes TXXXX

Signed-off-by: Your Name <your@email.com>

In your case it would be:

Initial Commit of QMMP

The inclusion of qmmp fixes T5356

Signed-off-by: Brian Urbina <brian.urbina@outlook.com>

P.S.: You have to make some modifications in your package.yml.

package.yml
7

Should be GPL-2.0-or-later.

12

The order of the dependencies should be in alphabetical order like this:

- pkgconfig(libexample)
- pkgconfig32(libexample)
- example-tools

Search for package duplicates like pkgconfig(flac) pkgconfig(flac++)

Also the indentation is not 8 spaces, it's 4 spaces

melosaiyan updated this revision to Diff 19772.Feb 15 2020, 1:47 PM
melosaiyan retitled this revision from Initial Commit of QMMP to Initial Commit of QMMP The inclusion of qmmp fixes T5356.

Updating D8150: Initial Commit of QMMP

The inclusion of qmmp fixes T5356

@YakoYakoYokuYoku Thank you so much for your help! I finally got around to making additional changes. Hopefully I included all the necessary changes for review.

melosaiyan updated this revision to Diff 19773.Feb 15 2020, 1:53 PM
melosaiyan retitled this revision from Initial Commit of QMMP The inclusion of qmmp fixes T5356 to Initial Commit of QMMP Added correct GPL license info and the inclusion of qmmp fixes T5356.

Updating D8150: Initial Commit of QMMP

Added correct GPL license info and the inclusion of qmmp fixes T5356

DataDrake requested changes to this revision.Apr 12 2020, 8:59 PM
DataDrake added a subscriber: DataDrake.

@melosaiyan The correct place to mention that it "Fixes TNNN" is in the summary. You don't need to have it in the commit message.

package.yml
11

Please make sure that you aren't listing any pkgconfigs that are dependencies of the ones already listed.

pspec_x86_64.xml
8

You changed it in the pacakge.yml, but a rebuild is needed to fix it in the pspec.

This revision now requires changes to proceed.Apr 12 2020, 8:59 PM
JoshStrobl abandoned this revision.May 21 2020, 9:31 AM
JoshStrobl added a subscriber: JoshStrobl.

Closing due to lack of response.