Page MenuHomeSolus

Initial commit of wraith-master
ClosedPublic

Authored by serebit on Jan 30 2020, 9:20 PM.
Tags
None
Subscribers
Tokens
"Yellow Medal" token, awarded by EbonJaeger."Yellow Medal" token, awarded by Staudey."Pterodactyl" token, awarded by davidjharder.

Details

Summary

Initial commit. Includes both the CLI frontend and the GTK frontend, starting with version 0.5.0.

Test Plan

Verified that udev rules applied correctly, modified fan and ring colors using both frontends.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

serebit created this revision.Jan 30 2020, 9:20 PM
serebit requested review of this revision.Jan 30 2020, 9:20 PM

Notes

  • This package bundles both the GTK frontend and the command-line frontend into one package, instead of separate packages like in the AUR. This is because Solus cannot be installed without a desktop environment, unlike Arch, and therefore there is no need to separate the two artifacts. I can still separate the two if desired by the core team.
  • networking: true is required to resolve both the dependencies of Kotlin/Native, and the Gradle wrapper. Approximately 880 MB is downloaded for each build. This number can be reduced to 780 MB if Solus updates Gradle to a newer version, which would require the JDK upgrade.
  • As Wraith Master is built with Kotlin/Native rather than Kotlin/JVM, the JDK is not required as a rundep, only as a builddep.
  • I wasn't sure what component to put this in, as piper is in system.utils and ckb is in desktop.core, so I went with system.utils. I can change the component if need be.

Is there no way for you to vendor in the deps in the tarballs? 700MB for each build, since it won't be cached, is pretty expensive.

JoshStrobl added inline comments.Jan 31 2020, 3:38 PM
MAINTAINERS.md
3

Should be:

- Campbell Jones
  - IRC: serebit
  - Email: dev@serebit.com

As in not have it immediately be indented two spaces.

Is there no way for you to vendor in the deps in the tarballs? 700MB for each build, since it won't be cached, is pretty expensive.

I can add the Kotlin/Native dependencies as individual sources, yeah. I'll see what I can do.

serebit updated this revision to Diff 19492.Jan 31 2020, 8:08 PM

Add K/N dependencies as sources, use packaged gradle, and fix MAINTAINERS file

serebit marked an inline comment as done.Jan 31 2020, 8:09 PM
serebit updated this revision to Diff 19583.Feb 5 2020, 5:49 PM

Remove two sources, upping per-build download size to about 30-40 MB

serebit updated this revision to Diff 19745.Feb 13 2020, 9:36 PM

Updated to 0.4.1

JoshStrobl requested changes to this revision.Feb 14 2020, 3:42 AM

Otherwise LGTM, thank you for shrinking the deps it needs to pull in during build time, it's seriously appreciated!

package.yml
28

This should be after the pkgconfigs, with the gtk3 pkgconfig being before the libusb one.

This revision now requires changes to proceed.Feb 14 2020, 3:42 AM

Otherwise LGTM, thank you for shrinking the deps it needs to pull in during build time, it's seriously appreciated!

Of course! Just one question—I won't have access to my main computer for a few days, so is it okay to just edit the diff in Phabricator for this change?

Otherwise LGTM, thank you for shrinking the deps it needs to pull in during build time, it's seriously appreciated!

Of course! Just one question—I won't have access to my main computer for a few days, so is it okay to just edit the diff in Phabricator for this change?

I assume you mean by downloading the diff, editing it then using the upload feature. Go for it.

serebit updated this revision to Diff 19757.Feb 14 2020, 5:44 AM
serebit edited the summary of this revision. (Show Details)

Reorder build dependencies

serebit marked an inline comment as done.Feb 14 2020, 5:44 AM
serebit updated this revision to Diff 19803.Feb 17 2020, 3:44 PM

Rebuild with reordered dependency list

@JoshStrobl Alright, that should be everything! Let me know if there's anything else I should change, otherwise this should be ready to commit on your next pass :)

JoshStrobl requested changes to this revision.Feb 19 2020, 8:37 AM

Seems environment was moved above builddeps. Typically we keep those bundled with the rest of the steps (setup, build, install, check, profile).

Other than that it was good. Excellent work :)

This revision now requires changes to proceed.Feb 19 2020, 8:37 AM
serebit updated this revision to Diff 19859.Feb 19 2020, 2:33 PM

Move environment below build deps. Ready for landing!

JoshStrobl accepted this revision.Feb 19 2020, 2:34 PM
JoshStrobl added a subscriber: DataDrake.

LGTM, I'll get this landed after @DataDrake is done with kernels 🎉

This revision is now accepted and ready to land.Feb 19 2020, 2:34 PM
serebit updated this revision to Diff 19913.Feb 21 2020, 6:18 PM

Update to 0.4.2

serebit updated this revision to Diff 20089.Mar 2 2020, 4:14 AM

Update to 0.5.0 and switch to using Gradle wrapper. Gradle version in repos is now too old to build Wraith Master

serebit edited the summary of this revision. (Show Details)Mar 2 2020, 4:14 AM
JoshStrobl accepted this revision.Mar 2 2020, 2:41 PM

LGTM, landing now :)

This revision was automatically updated to reflect the committed changes.