Page MenuHomeSolus

Initial inclusion of Kraft
ClosedPublic

Authored by EbonJaeger on Jan 26 2020, 10:02 PM.

Details

Summary

Initial inclusion of Kraft, a business quote and invoice software.
Currently requires a patch to use python3, using the existing commits in the Kraft repo. Patches can be dropped in a future release.

Depends on D8113
Depends on D8114

Resolves T8617

Test Plan

Use Kraft to generate multiple different invoices with different layouts, and generate a printable PDF.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

EbonJaeger created this revision.Jan 26 2020, 10:02 PM
EbonJaeger requested review of this revision.Jan 26 2020, 10:02 PM

Fix a shebang

livingsilver94 added inline comments.
files/0001-use-python3.patch
36

Is this your typo or theirs?

EbonJaeger added inline comments.Jan 26 2020, 11:04 PM
files/0001-use-python3.patch
36

Theirs.

JoshStrobl requested changes to this revision.Jan 31 2020, 4:28 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
21

pkgconfigs should always be before explicit package names

This revision now requires changes to proceed.Jan 31 2020, 4:28 PM
EbonJaeger updated this revision to Diff 19486.Jan 31 2020, 7:10 PM

Place pkgconfigs above explicit package names

EbonJaeger marked an inline comment as done.Jan 31 2020, 7:10 PM
JoshStrobl accepted this revision.Jan 31 2020, 7:17 PM

LGTM, thanks!

This revision is now accepted and ready to land.Jan 31 2020, 7:17 PM
This revision was automatically updated to reflect the committed changes.