Page MenuHomeSolus

Initial inclusion of ctemplate
ClosedPublic

Authored by EbonJaeger on Jan 26 2020, 9:58 PM.

Details

Summary

Initial inclusion of the ctemplate C++ library. This is required for Kraft.
I am using the latest git commit for python3 support. A new release has not yet been for python3, but this will use that tag when it happens.

Ref T8617

Test Plan

Build and test Kraft using this package.

Diff Detail

Repository
R4894 ctemplate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

EbonJaeger created this revision.Jan 26 2020, 9:58 PM
EbonJaeger requested review of this revision.Jan 26 2020, 9:58 PM

Note for Core team: As per the Kraft task, the author is looking to migrate away from using ctemplate. There is recent activity on the development of this library, but if there is a better alternative it may be more prudent to wait for Kraft to migrate, and drop this package. I'll leave that up to you guys.

JoshStrobl requested changes to this revision.Fri, Jan 31, 4:25 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
6

master

Nononononono. That will affect the reproducability of builds. Should stick with a specific commit then occasionally move it forward until this can be nuked.

pspec_x86_64.xml
30

All of /usr/share/doc can be nuked. Nothing useful here.

This revision now requires changes to proceed.Fri, Jan 31, 4:25 PM
EbonJaeger added inline comments.Fri, Jan 31, 5:10 PM
package.yml
6

:facepalm: You're right. Sorry about that.

EbonJaeger updated this revision to Diff 19485.Fri, Jan 31, 7:03 PM

Use a fixed commit to build from, and remove the included docs

EbonJaeger marked 2 inline comments as done.Fri, Jan 31, 7:03 PM
JoshStrobl accepted this revision.Fri, Jan 31, 7:15 PM

LGTM, thanks!

This revision is now accepted and ready to land.Fri, Jan 31, 7:15 PM
This revision was automatically updated to reflect the committed changes.