Page MenuHomeSolus

First release of Stremio Shell on Solus
AbandonedPublic

Authored by Alexandru-Balan on Jan 25 2020, 3:51 PM.

Details

Reviewers
None
Group Reviewers
Triage Team
Summary

Initial release of Stremio on Solus

This is related to [T7415]. Also mentioned in some closed threads: [T7909] and [T4493]

Package changes
It now uses macros as Josh and kyrios suggested, thank you.

Test Plan

Installed stremio, loged-in, searched for a podcast and played it.
Also tested local videos and over-the-internet videos.
All functions seem to be working normally.

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alexandru-Balan requested review of this revision.Jan 25 2020, 3:51 PM
Alexandru-Balan edited the summary of this revision. (Show Details)

Added context of this package

Updated script to use macros

Alexandru-Balan edited the summary of this revision. (Show Details)Jan 25 2020, 8:04 PM
Alexandru-Balan added a subscriber: Alexandru-Balan.
Alexandru-Balan edited the summary of this revision. (Show Details)Jan 27 2020, 8:06 PM
JoshStrobl abandoned this revision.Jan 29 2020, 4:00 PM
JoshStrobl added a subscriber: JoshStrobl.

Rejecting, T7415 has not yet been explicitly marked as accepted for inclusion.

Then why not close [T7415] altogether? I wouldn't have worked on this at all if I knew. Or is it possible that it will be marked for inclusion in the future?

[...]Or is it possible that it will be marked for inclusion in the future?

Exactly. That's why the issue hasn't been closed and why Josh said "yet". There might still come a time when you can submit your patch.

[...]Or is it possible that it will be marked for inclusion in the future?

Exactly. That's why the issue hasn't been closed and why Josh said "yet". There might still come a time when you can submit your patch.

Oh alright then. Thanks for clarification. I'll stop necrobumping this now :)