Details
- Reviewers
ikey - Group Reviewers
Triage Team - Commits
- R575:b33e9654244a: Update cups to 2.2.6 + convert to ypkg
Installation ok
Diff Detail
- Repository
- R575 cups
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| package.yml | ||
|---|---|---|
| 4 | I'm not experienced enough to comment on the rest of the package, but the release number should be 16. | |
| files/cups-multilib.patch | ||
|---|---|---|
| 10 ↗ | (On Diff #1781) | This stuff seems cranky and wrong, we didn't need a multilib patch before so why do we need one now.. ? |
| files/cups-no-export-ssllibs.patch | ||
| 9 ↗ | (On Diff #1781) | I need clarification on why this patch is present - Fedora having it isn't a good enough reason |
| package.yml | ||
| 45 | Can I see the build failure? We might have a dependency issue in the 32-bit build of gnutls | |
| 58 | Please be sure to use 5-octal notation, i.e. 00644 not 644. This is a very little documented part of install, but it clears parent permission problems. For example, if somehow an upper directory becomes setgid, then install will continue that setgid mask across -D subdirectory creation, which can be incredibly dangerous! :) | |
| pspec_x86_64.xml | ||
| 24 | Guess Ikey needs to make this stateless at some point :P | |
| files/cups-no-export-ssllibs.patch | ||
|---|---|---|
| 9 ↗ | (On Diff #1781) | ok I only leave the patches that I believe are really important. |
| package.yml | ||
| 45 | This is what I get when gnutls is enabled for the 32bit build: | |
libgnutls-32bit should depend on libp11-kit-32bit but doesn't (the non 32bit package has the correct dependency).
If you can't justify why you are adding a patch, you shouldn't add it IMO
DRAFT - Update 1
- Removed some patches
- Don't gzip man pages in the Makefile
- Prevent multilib conflict in cups-config script
- Don't export SSLLIBS to cups-config.
- add tmpfiles
- fix release number
- use octal permissions in install -m
- Remove Fedora hacks to log into the journal instead of syslog: first make it work, enhance it later.
- Add some more configure options (user, group, system groups, without rcdir)
This could be considered as the release candidate version of the package. It's ready for testing and if nobody ask for changes, it can be committed ?
You're a wise man and I wouldn't want to feel responsible for breaking printing for everyone !
| package.yml | ||
|---|---|---|
| 56 | make check is currently commented because 1 test fails: ./testhttp | |
I have a printer but am not currently using unstable @kyrios123 I could maybe setup a virtual machine if you would like
Any help for testing is welcome but the package is not yet on unstable.
I uploaded the .eopkg files here.
PS: if you set a virtual machine on stable, it should also work if the system is up-to-date.
The Gentoo patch for the systemd units breaks the existing paths in our cups package, thus breaks upgrades
bump to 2.2.5
- restore original service, socket & path names
- add libgcrypt-32bit-devel and xz-32bit-devel as dependencies because cups doesn't build anymore without them