Page MenuHomeSolus

Update cups-filters to 1.26.2
ClosedPublic

Authored by kyrios123 on Tue, Jan 14, 8:50 PM.

Details

Summary
  • cups-browsed: Added crash guards to avoid crashes in case the dummy printer entry for a deleted master entry is used.
  • cups-browsed: Set the port of the local CUPS daemon to be used according to the IPP_PORT environment variable.
  • cups-browsed: Eliminated the use of the cupsGetPPD2() function of libcups completely, also the remaining calls in the record_printer_options() and update_cups_queues() functions, the former causing incomplete recording of option settings and the latter use of CUPS-generated PPDs not working when CUPS is running on a non-standard port.
  • cups-browsed: Eliminated the use of the cupsGetPPD2() function of libcups in queue_overwritten(). The function actually loads the queue's PPD file if the queue is on a local CUPS on port 631. Due to a bug the function fails if an alternative port is used. This lets queue_overwritten() always assume that the PPD got removed and therefore the queue got overwritten. So queues got released from cups-browsed if it was printed on them or if they were supposed to be removed on shutdown.
  • foomatic-rip: Fixed compilation with -fno-common.

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Unit tests are OK

Diff Detail

Repository
R576 cups-filters
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kyrios123 created this revision.Tue, Jan 14, 8:50 PM
kyrios123 requested review of this revision.Tue, Jan 14, 8:50 PM
JoshStrobl accepted this revision.Wed, Jan 15, 8:14 AM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision is now accepted and ready to land.Wed, Jan 15, 8:14 AM
This revision was automatically updated to reflect the committed changes.