Including toggl-desktop fixes T4446
AbandonedPublic
Actions

Authored by netchup on Jan 11 2020, 8:54 PM.

Details

Reviewers

DataDrake

Group Reviewers

Triage Team

Summary

Package is working, tested basic functionality - login and tracking time is working. I don't have information about reminder. Able to maintain this package, cos i use it on daily basis.

Test Plan

Installed eopkg, logged in and tested recording time.

Diff Detail

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

netchup created this revision.Jan 11 2020, 8:54 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptJan 11 2020, 8:54 PM

netchup requested review of this revision.Jan 11 2020, 8:54 PM

netchup retitled this revision from Including new package fixes T4446 to Including toggl-desktop fixes T4446.Jan 12 2020, 8:01 AM

DataDrake requested changes to this revision.Jan 14 2020, 1:21 AM

DataDrake added a subscriber: DataDrake.

DataDrake added inline comments.

package.yml
7	I think this probably belongs in `office` more than `desktop`.
16	Should be using pkgconfigs for this and the next two.
19	I'd rather have two packages with the one typically getting installed having a smaller install size.
21	No newline needed
24	Extra trailing slash
pspec_x86_64.xml
24	All of these should be /usr/lib64
27	This looks like a vendored library that shouldn't be directly in /usr/lib
45	File conflict.