Page MenuHomeSolus

Update libvirt to 5.10.0
Needs ReviewPublic

Authored by YakoYakoYokuYoku on Fri, Jan 10, 2:05 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

The update of libvirt to 5.10.0 adds lots of changes since version
4.8.0 (browseable changes).
Dropped the build and installation of the documentation as it cannot
be installed any more and also it's already available at the official
site.

Signed-off-by: Martin Reboredo <gc1000ll@gmail.com>

Test Plan

Launch a Debian VM with MATE desktop and run a lua hello world in virt-manager.

Diff Detail

Repository
R1891 libvirt
Branch
arcpatch-D8029
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

YakoYakoYokuYoku requested review of this revision.Fri, Jan 10, 2:05 PM
JoshStrobl requested changes to this revision.EditedFri, Jan 10, 2:47 PM
JoshStrobl added a subscriber: JoshStrobl.

docs package has been removed without explanation, that should probably be restored. There's also ABI removals so you need to basically rebuild everything against this and validate the changes. We also don't do 80 columns and use Markdown in changelogs.

package.yml
49

No you should be using the reconfigure macro.

50

Why are you doing this in a build dir now?

This revision now requires changes to proceed.Fri, Jan 10, 2:47 PM
YakoYakoYokuYoku edited the summary of this revision. (Show Details)

Formatted properly the message

JoshStrobl requested changes to this revision.Fri, Jan 10, 4:05 PM

Their change to enforce separate build directories is dumb, their reasoning is dumb (basically "another build system we're not even using does this, so let's do it too"), so let's revert it. Please revert the changes based in https://github.com/libvirt/libvirt/commit/f96395e78eaccffbf128336382c74b1250f04032 in a patch. Also you didn't address my issues with the summary or the docs.

This revision now requires changes to proceed.Fri, Jan 10, 4:05 PM
YakoYakoYokuYoku edited the summary of this revision. (Show Details)

Dropped the packaging of documentation as it's now pointless