Page MenuHomeSolus
Differential D8028

"Inclusion of torsocks fixes T4354 and T4237"
AbandonedPublic
Actions

Authored by netchup on Jan 10 2020, 11:23 AM.
Tags
None
Referenced Files
F11043645: D8028.diff
Thu, Aug 10, 8:22 AM
F11038626: D8028.id19211.diff
Wed, Aug 9, 11:16 PM
F11038625: D8028.id19224.diff
Wed, Aug 9, 11:16 PM
F11038624: D8028.id.diff
Wed, Aug 9, 11:16 PM
F11038620: D8028.id19226.diff
Wed, Aug 9, 11:16 PM
F11038619: D8028.id19227.diff
Wed, Aug 9, 11:16 PM
F11027562: D8028.diff
Wed, Aug 9, 4:42 AM
F10990948: D8028.id19224.diff
Mon, Jul 24, 11:15 PM
View All 18 Files
Subscribers
JoshStrobl

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary

tor service must be at least started to use torsocks

Test Plan

After compilation, just installed and tested with "torsocks curl ifconfig.me" that says different IP than mine. The tor service must be started manually.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

netchup created this revision.Jan 10 2020, 11:23 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptJan 10 2020, 11:23 AM
netchup requested review of this revision.Jan 10 2020, 11:23 AM
JoshStrobl requested changes to this revision.Jan 10 2020, 11:29 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
7

Should probably be security.utils

12

Excessive indentation. Only needs to be 4 spaces.

pspec_x86_64.xml
24

static libraries should be disabled. Try --disable static as a flag after %reconfigure

28

Docs should either be disabled (if there is a configure option for it) or nuked.

This revision now requires changes to proceed.Jan 10 2020, 11:29 AM
netchup updated this revision to Diff 19224.Jan 10 2020, 5:24 PM
netchup marked an inline comment as done.

fixes

netchup updated this revision to Diff 19226.Jan 10 2020, 5:28 PM
netchup marked 2 inline comments as done.

Fixed component and indentation

netchup updated this revision to Diff 19227.EditedJan 10 2020, 5:31 PM
netchup marked an inline comment as done.

ready for next review

JoshStrobl requested changes to this revision.Jan 15 2020, 8:16 AM

As per our docs, you should not be doing a git commit (supplemental commit to your initial one), you should be appending your original commit: https://getsol.us/articles/packaging/submitting-a-package/en/#updating-a-patch-that-needs-changes

This revision now requires changes to proceed.Jan 15 2020, 8:16 AM
JoshStrobl abandoned this revision.Apr 8 2020, 3:56 PM

Closing due to not addressing issues raised in 30+ days.

Revision Contents
Changeset List

PathSize
8 lines
9 lines

Diff 19226

View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.