Differential D8028

"Inclusion of torsocks fixes T4354 and T4237"
AbandonedPublic
Actions

Authored by netchup on Jan 10 2020, 11:23 AM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Summary

tor service must be at least started to use torsocks

Test Plan

After compilation, just installed and tested with "torsocks curl ifconfig.me" that says different IP than mine. The tor service must be started manually.

Diff Detail

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

netchup created this revision.Jan 10 2020, 11:23 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptJan 10 2020, 11:23 AM

netchup requested review of this revision.Jan 10 2020, 11:23 AM

JoshStrobl requested changes to this revision.Jan 10 2020, 11:29 AM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
7	Should probably be security.utils
12	Excessive indentation. Only needs to be 4 spaces.
pspec_x86_64.xml
24	static libraries should be disabled. Try `--disable static` as a flag after `%reconfigure`
28	Docs should either be disabled (if there is a configure option for it) or nuked.

This revision now requires changes to proceed.Jan 10 2020, 11:29 AM

fixes

Fixed component and indentation

ready for next review

As per our docs, you should not be doing a git commit (supplemental commit to your initial one), you should be appending your original commit: https://getsol.us/articles/packaging/submitting-a-package/en/#updating-a-patch-that-needs-changes

This revision now requires changes to proceed.Jan 15 2020, 8:16 AM

Closing due to not addressing issues raised in 30+ days.

Revision Contents
Changeset List

			Path	Packages
M			package.yml (8 lines)
M			pspec_x86_64.xml (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	19211	4b825dc		Jan 10 2020, 11:23 AM	★	★
Diff 2	19224	8f98fc6	fixes	Jan 10 2020, 5:24 PM	★	★
Diff 3	19226	8f98fc6	Fixed component and indentation	Jan 10 2020, 5:28 PM	★	★
Diff 4	19227	8f98fc6	now i know how the webui works, i need to check, later submit the diff	Jan 10 2020, 5:31 PM	★	★

"Inclusion of torsocks fixes T4354 and T4237"AbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 19227

package.yml

pspec_x86_64.xml

"Inclusion of torsocks fixes T4354 and T4237"
AbandonedPublic
Actions

Revision Contents
Changeset List