Page MenuHomeSolus

quakespasm: switch from libmad to libmpg123 for MP3 decoding

Authored by aleksvor on Mon, Jan 6, 12:07 PM.



The reasons for switching are:

  1. mpg123 gives better performance than mad (see this benchmark for example).
  2. mpg123 is still being developed and maintained, while last release of libmad was made in 2004.
Test Plan

Copied MP3 soundtrack in id1/music directory and verified that the game correctly decodes and plays back MP3 files.

Diff Detail

R2768 quakespasm
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aleksvor created this revision.Mon, Jan 6, 12:07 PM
aleksvor requested review of this revision.Mon, Jan 6, 12:07 PM
Jacalz awarded a token.Mon, Jan 6, 2:28 PM
JoshStrobl accepted this revision.Thu, Jan 9, 9:26 AM
JoshStrobl added a subscriber: JoshStrobl.

Seems like quite a reasonable change. Thanks!

This revision is now accepted and ready to land.Thu, Jan 9, 9:26 AM