Page MenuHomeSolus

Initial release of rinutils
ClosedPublic

Authored by Girtablulu on Jan 5 2020, 6:33 PM.

Details

Summary

Initial release of rinutils

Test Plan

build freesolver 5.16 which is needed for kpat 19.12.0 and I played a round with kpat

Diff Detail

Repository
R4883 rinutils
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Girtablulu created this revision.Jan 5 2020, 6:33 PM
Girtablulu requested review of this revision.Jan 5 2020, 6:33 PM
DataDrake requested changes to this revision.Jan 7 2020, 9:10 PM
DataDrake added a subscriber: DataDrake.

I think this should be libsplit: no since it's only headers and pkgconfig/cmake.

This revision now requires changes to proceed.Jan 7 2020, 9:10 PM
Girtablulu requested review of this revision.Jan 7 2020, 11:10 PM

still splits the stuff if I set the key

Sorry, it's split not libsplit.

still doesn't work and checking the repo we are using libsplit as far as I could see, or is it different for ninja?

@Girtablulu libsplit only keeps the library file (lib*.so) from entering the devel subpackage, but it does nothing to the header files. I think you will need to use the patterns key to require the headers also go to the main package. You can look at the eigen3 package as a template.

Girtablulu updated this revision to Diff 19183.Jan 8 2020, 6:01 PM

no libsplit

JoshStrobl accepted this revision.Jan 9 2020, 9:34 AM
JoshStrobl added a subscriber: JoshStrobl.

LGTM, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Jan 9 2020, 1:34 PM
This revision was automatically updated to reflect the committed changes.