Page MenuHomeSolus

Enable sftp support
ClosedPublic

Authored by cybre on May 9 2017, 11:22 PM.

Details

Summary

Enable sftp support in curl. Depends on D79

Diff Detail

Repository
R578 curl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cybre created this revision.May 9 2017, 11:22 PM
cybre updated this revision to Diff 124.May 9 2017, 11:25 PM

Removed unneeded command

JoshStrobl requested changes to this revision.May 10 2017, 2:06 PM
JoshStrobl added a subscriber: JoshStrobl.

Release needs to be bumped to 29. It'll fix the pspec bits too.

This revision now requires changes to proceed.May 10 2017, 2:06 PM
cybre updated this revision to Diff 144.May 10 2017, 7:05 PM
cybre edited edge metadata.
  • Bump to 29

You bumped the package.yml but the pspec never got rebuilt.

cybre added a comment.May 10 2017, 9:20 PM

You bumped the package.yml but the pspec never got rebuilt.

Damn. Looks like I didn't git add it :/.
One pspec coming right up!
Pretty obvious that I haven't done any packaging in a while :D

cybre updated this revision to Diff 145.May 10 2017, 9:21 PM
  • Include the rebuilt pspec
JoshStrobl accepted this revision.May 10 2017, 9:24 PM
JoshStrobl added a subscriber: ikey.

There we go, now we're talkin :D

Gonna have @ikey review it. *Doubt* he'll have any objections to SFTP support in CURL but ya know, system.base and I'd rather than not blow something up :P

This revision is now accepted and ready to land.May 10 2017, 9:24 PM

Talked with @ikey and we opted to move libssh2 to system.base. This patch will land as well, appreciated :)

This revision was automatically updated to reflect the committed changes.