Page MenuHomeSolus
Differential D799

Update tk to 8.6.8
ClosedPublic
Actions

Authored by kyrios123 on Aug 10 2017, 9:05 PM.
Tags
Referenced Files
F11054504: D799.id6119.diff
Fri, Aug 11, 12:52 AM
F11054503: D799.id1749.diff
Fri, Aug 11, 12:52 AM
F11054502: D799.id6054.diff
Fri, Aug 11, 12:52 AM
F11054501: D799.id4188.diff
Fri, Aug 11, 12:52 AM
F11054500: D799.id5737.diff
Fri, Aug 11, 12:52 AM
F11054499: D799.id4189.diff
Fri, Aug 11, 12:52 AM
F11054498: D799.id5955.diff
Fri, Aug 11, 12:52 AM
F11054497: D799.id4069.diff
Fri, Aug 11, 12:52 AM
View All 26 Files
Subscribers
DataDrake

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Maniphest Tasks
T4399: gitk fails with error "/usr/bin/gitk: line 3: exec: wish: not found"
Commits
R3045:34769ac551ab: Update tk to 8.6.8
Summary

Packaging:

  • package.yml reformatting
  • add private headers
  • make sure all libs are installed under /usr/lib64
  • Fix/cleanup tkConfig.sh
  • unhardcode version number where possible

Depends on D798.

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan
wish8.6 
% puts $tcl_version
8.6
% puts $tk_version
8.6

Also tried with python tkinter:

python3
Python 3.5.2 (default, Nov 12 2016, 19:04:03) 
[GCC 6.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from tkinter import *
>>> win = Tk()
>>> label = Label(win, text="hello solus")
>>> label.pack()

Tested gitk against this version

Diff Detail

Repository
R3045 tk
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kyrios123 created this revision.Aug 10 2017, 9:05 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptAug 10 2017, 9:05 PM
DataDrake requested changes to this revision.Dec 17 2017, 6:12 PM
DataDrake added a subscriber: DataDrake.

Please rebase.

This revision now requires changes to proceed.Dec 17 2017, 6:12 PM
kyrios123 updated this revision to Diff 4069.EditedDec 17 2017, 6:40 PM
kyrios123 edited edge metadata.
kyrios123 added a task: T4399: gitk fails with error "/usr/bin/gitk: line 3: exec: wish: not found".

Rebased

kyrios123 updated this revision to Diff 4188.Dec 22 2017, 9:25 PM
kyrios123 retitled this revision from Update tk to 8.6.7 to Update tk to 8.6.8.
kyrios123 edited the summary of this revision. (Show Details)

Bump to 8.6.8

kyrios123 updated this revision to Diff 4189.Dec 22 2017, 9:48 PM
kyrios123 edited the summary of this revision. (Show Details)

add private headers and use /usr/lib64 just like tcl package

DataDrake requested changes to this revision.Feb 24 2018, 7:31 PM

If possible, I'd like to see:

  1. /usr/lib64/tk8.6/demos in a -demos package
  2. /usr/lib64/tk8.6/include in -devel if it isn't needed for normal execution.

Thanks!

This revision now requires changes to proceed.Feb 24 2018, 7:31 PM
kyrios123 updated this revision to Diff 5737.Feb 25 2018, 3:28 PM

Add requested patterns.

Run wish from a terminal did pop up a window, so I guess it's fine ?

DataDrake added a comment.Mar 3 2018, 3:15 PM

Can you test gitk too? IT's usually the one to get derpy. Thanks!

kyrios123 added a comment.Mar 5 2018, 8:44 PM
In D799#37273, @DataDrake wrote:

Can you test gitk too? IT's usually the one to get derpy. Thanks!

I suppose you mean git ? If so it's tested since latest tcl & tk are installed on my system and I did submit many patches here and on github without any problem.

kyrios123 updated this revision to Diff 5955.Mar 8 2018, 8:05 AM

Nuke blank line at eof

DataDrake added a comment.Mar 11 2018, 1:00 PM
In D799#37525, @kyrios123 wrote:
In D799#37273, @DataDrake wrote:

Can you test gitk too? IT's usually the one to get derpy. Thanks!

I suppose you mean git ? If so it's tested since latest tcl & tk are installed on my system and I did submit many patches here and on github without any problem.

gitk is a GUI for git (written in tcl/tk) that is included in the git package.

kyrios123 edited the test plan for this revision. (Show Details)Mar 11 2018, 4:12 PM
kyrios123 updated this revision to Diff 6054.Mar 11 2018, 4:17 PM

I confirm gitk is working fine with this version

DataDrake accepted this revision.Mar 12 2018, 1:47 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Mar 12 2018, 1:47 AM
Closed by commit R3045:34769ac551ab: Update tk to 8.6.8 (authored by kyrios123). · Explain WhyMar 13 2018, 3:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
22 lines
16 lines

Diff 1749

View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.