Page MenuHomeSolus

Update atom to 1.44.0 and switch to prebuilt tarball
ClosedPublic

Authored by Jacalz on Dec 20 2019, 5:02 PM.
Tags
None
Referenced Files
F10814962: D7867.diff
May 31 2023, 6:18 PM
F10814760: D7867.id19691.diff
May 31 2023, 5:22 PM
F10778223: D7867.id.diff
May 24 2023, 5:46 AM
F10774531: D7867.id19691.diff
May 22 2023, 7:21 AM
F10691966: D7867.id.diff
Apr 24 2023, 2:28 AM
Subscribers

Details

Summary

The release notes can be found on the Atom releases page here.

Packaging Changes:

  • Switch to tarballs prebuilt by atom developers. This makes the file indexing and project searching finally work again and makes packaging hugesly simpler as it cuts down on build time and avoids build issues using NODE version 12.
Test Plan
  • Test project searching, file indexing and so on.
  • Test that .go files load and function as expected.
  • Verify the version in the about page.

Diff Detail

Repository
R394 atom
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

No...if there is an issue we should be working with the Atom developers on addressing it, not just switching to their tarballs. That isn't an acceptable solution.

No...if there is an issue we should be working with the Atom developers on addressing it, not just switching to their tarballs. That isn't an acceptable solution.

The problem is that atom developers don’t want to help custom built atom versions at all. There are also a lot of little stuff that I just can’t get working with building it because I have no idea at all on how to fix them (take file indexing and search in project as an example and builds why fail for no apparent reason). This solution fixes all issues and makes maintaining atom much less a pain in the ****.

I have switched to vscode (due to totally different reasons) and saw this as a good way to keep maintaining atom. If this isn’t accepted, I will stop maintaining the package because I simply don’t have the time to deal with annoying electron apps that seem to not be meant to be packaged.

I am sorry that it had to be this way, but with me switching editor and studies picking up from next year and forward, I simply see lesser reason to maintain this with all the quirks that it has.

In my eyes, this is the best solution available...

Is the answer still no for this one or have you changed your mind? @JoshStrobl
The new update to 1.43.0 fixed nothing for me in regards to building it :(

Jacalz retitled this revision from Update atom to 1.42.0 and switch to prebuilt tarball to Update atom to 1.43.0 and switch to prebuilt tarball.Jan 18 2020, 1:07 PM
Jacalz edited the summary of this revision. (Show Details)

Honestly at this point, I've stopped caring about it too. If the atom folks aren't even willing to assist with third-party builds of their own software, they're helpless and quite frankly the only way we could wipe our hands more clean of this package is to nuke it from the repo, which isn't something that's on the table.

So yea, let's just move to their own binary. If people have problems with it, the only people to blame are Atom devs.

package.yml
35

Unnecessary comment is unnecessary :P

36

Let's just nuke all the fine contents. If they don't want to clean up their own node_modules for their own binaries, that's on them. Let's not help them out.

This revision now requires changes to proceed.Jan 31 2020, 4:33 PM
package.yml
36

Could you please explain more clearly what you want me to do?
I think this is quite good as is and it does help with making the install a bit smaller which is necessary with these terrible electron apps.

  • Simple cleanups of the package.yml
Jacalz marked an inline comment as done and an inline comment as not done.Feb 2 2020, 1:14 PM
package.yml
36

I want you to nuke all the find removes. Last thing I want is the Atom developers refusing even more support just because we remove files from their binary.

This revision now requires changes to proceed.Feb 6 2020, 5:41 PM
  • Remove the find and remove stuff
Jacalz retitled this revision from Update atom to 1.43.0 and switch to prebuilt tarball to Update atom to 1.44.0 and switch to prebuilt tarball.Feb 10 2020, 6:50 PM
Jacalz edited the summary of this revision. (Show Details)
Jacalz edited the summary of this revision. (Show Details)

LGTM, thanks for the changes!

This revision is now accepted and ready to land.Feb 10 2020, 9:51 PM