Page MenuHomeSolus
Differential D7851

Patch in fix for running AppImages on Linux 5.4.x
ClosedPublic
Actions

Authored by robertgzr on Dec 16 2019, 9:24 AM.
Tags
None
Referenced Files
F11053145: D7851.id18849.diff
Thu, Aug 10, 10:46 PM
F11053144: D7851.id18827.diff
Thu, Aug 10, 10:46 PM
F11053143: D7851.id18830.diff
Thu, Aug 10, 10:46 PM
F11053142: D7851.id18828.diff
Thu, Aug 10, 10:46 PM
F11053141: D7851.id18831.diff
Thu, Aug 10, 10:46 PM
F11053140: D7851.id.diff
Thu, Aug 10, 10:46 PM
F11037626: D7851.diff
Wed, Aug 9, 9:00 PM
F11010416: D7851.diff
Thu, Aug 3, 3:16 AM
View All 19 Files
Subscribers
Jacalz
JoshStrobl

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R756:03d879064926: Patch in fix for running AppImages on Linux 5.4.x
Summary

Fixes the following error when trying to use the --appimage flag on Linux>=5.4

Mounting appimage type 2
Error mounting appimage: appimage.c:122 appimage_set: Invalid argument
Test Plan

firejail --noprofile --appimage Spotify.AppImage works as expected.

Diff Detail

Repository
R756 firejail
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

robertgzr created this revision.Dec 16 2019, 9:24 AM
Herald added a reviewer: Triage Team. · View Herald TranscriptDec 16 2019, 9:24 AM
robertgzr requested review of this revision.Dec 16 2019, 9:24 AM
robertgzr added a comment.Dec 16 2019, 9:28 AM

I'm not sure what's going on with the pspec file here... I get this massive diff: https://paste.sr.ht/~robertgzr/a598cf3ca6dc4fb47017f357bedc05f9669015d2

can somebody tell me what to do with it?

Jacalz added a subscriber: Jacalz.EditedDec 16 2019, 9:32 AM
In D7851#125469, @robertgzr wrote:

I'm not sure what's going on with the pspec file here... I get this massive diff: https://paste.sr.ht/~robertgzr/a598cf3ca6dc4fb47017f357bedc05f9669015d2

can somebody tell me what to do with it?

You never bumped the package release. You can fix it by running the following commands:

rm pspec_x86_64.xml
make bump
make
robertgzr updated this revision to Diff 18828.Dec 16 2019, 9:49 AM

Bump package release, thanks @Jacalz o/

JoshStrobl requested changes to this revision.Dec 16 2019, 10:06 AM
JoshStrobl added a subscriber: JoshStrobl.

Let's get the description moved to be immediately after summary, otherwise LGTM, thanks!

This revision now requires changes to proceed.Dec 16 2019, 10:06 AM
robertgzr updated this revision to Diff 18830.Dec 16 2019, 4:36 PM

Let's get the description moved to be immediately after summary, otherwise LGTM, thanks!

done

robertgzr updated this revision to Diff 18831.EditedDec 16 2019, 4:40 PM

Add a reference to the upstream issue edit: (to the commit body)

JoshStrobl accepted this revision.Dec 17 2019, 6:24 PM

LGTM, thanks!

This revision is now accepted and ready to land.Dec 17 2019, 6:24 PM
Closed by commit R756:03d879064926: Patch in fix for running AppImages on Linux 5.4.x (authored by robertgzr, committed by JoshStrobl). · Explain WhyDec 17 2019, 6:24 PM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R756:03d879064926: Patch in fix for running AppImages on Linux 5.4.x.

Revision Contents
Changeset List

Diff 18849

View Options

files/0002-Fix-appimage-on-linux-5.4.x-kernel.patch

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.