Differential D783

build and add minizip from contrib
ClosedPublic
Actions

Authored by curantes on Aug 7 2017, 8:20 PM.

Details

Reviewers

joebonrichie

Group Reviewers

Triage Team

Commits

R3325:899f8815cb37: build and add minizip from contrib

Summary

Build and add minizip from contrib depends on T2545

Signed-off-by: Matthias Eliasson <matthias.eliasson@gmail.com>

Test Plan

I have tested to install and the libs are located the same place. Also made sure to split minizip to an own package (pattern).
No further tests have beem made.

Diff Detail

Repository

R3325 zlib

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

curantes created this revision.Aug 7 2017, 8:20 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptAug 7 2017, 8:20 PM

Not sure that I like the fact the subpackages aren't split off into further devels

In D783#11250, @ikey wrote:

Not sure that I like the fact the sub-packages aren't split off into further devels

I was actually a bit uncertain how to split this up. One way was to create a whole separate package repository for minizip but since this have been moved to zlib repository upstream for some time I also thought we could go with patterns and include this here. Also since minizip is just a lib we might just rename the pattern above and suffix the -devel and skip minizip?

Otherwise I am not sure how we would further split it.

@ikey: Do you have any suggestion in how you want minizip packaged?

curantes added a project: Patch Submission.Aug 15 2017, 9:13 PM

Interested in getting this in for Chromium

Check the contents of zlib and zlib-devel if you still aren't sure

package.yml
20–23	It would be something like this: - minizip: - /usr/lib64/libminizip.so.* - minizip-devel: - /usr/include/minizip/* - /usr/lib64/*.a - /usr/lib64/libminizip.so - /usr/lib64/pkgconfig/minizip.pc

Added chromium as a child dep as it bundles it's own zlib with minizip support, but ideally I would like the use the system library.

split minizip to devel pattern as well according to pointers from @ikey

joebonrichie accepted this revision.Oct 27 2017, 9:55 PM

This revision is now accepted and ready to land.Oct 27 2017, 9:55 PM

Closed by commit R3325:899f8815cb37: build and add minizip from contrib (authored by curantes, committed by joebonrichie). · Explain WhyOct 27 2017, 9:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			abi_symbols (65 lines)
M			abi_symbols32 (65 lines)
M			package.yml (40 lines)
M			pspec_x86_64.xml (86 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1714	c43ef31		Aug 7 2017, 8:20 PM	★	★
Diff 2	2741	c43ef31	split minizip to devel pattern as well according to pointers from @ikey	Oct 3 2017, 7:58 PM	★	★
Diff 3	3081	c43ef31	R3325:899f8815cb376cf6381ffe739c7ae408a40e1c8c	Oct 27 2017, 9:56 PM	★	★

Status	Author	Revision
Closed	joebonrichie	D996 transmission: add mandatory libcurl to builddeps
Needs Review	joebonrichie	D985 Initial inclusion of chromium
Closed	joebonrichie	D970 Update libicu to 59.1
Closed	curantes	D783 build and add minizip from contrib
Closed	joebonrichie	D994 libevent: update to 2.1.8
Abandoned	joebonrichie	D1605 Enable support for llvm's LLD linker
Closed	kyrios123	D1205 Update harfbuzz to 1.7.5
Abandoned	joebonrichie	D2683 Update llvm to 6.0.0