Page MenuHomeSolus

build and add minizip from contrib
ClosedPublic

Authored by curantes on Aug 7 2017, 8:20 PM.

Details

Summary

Build and add minizip from contrib depends on T2545

Signed-off-by: Matthias Eliasson <matthias.eliasson@gmail.com>

Test Plan

I have tested to install and the libs are located the same place. Also made sure to split minizip to an own package (pattern).
No further tests have beem made.

Diff Detail

Repository
R3325 zlib
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
curantes created this revision.Aug 7 2017, 8:20 PM

Not sure that I like the fact the subpackages aren't split off into further devels

In D783#11250, @ikey wrote:

Not sure that I like the fact the sub-packages aren't split off into further devels

I was actually a bit uncertain how to split this up. One way was to create a whole separate package repository for minizip but since this have been moved to zlib repository upstream for some time I also thought we could go with patterns and include this here. Also since minizip is just a lib we might just rename the pattern above and suffix the -devel and skip minizip?

Otherwise I am not sure how we would further split it.

@ikey: Do you have any suggestion in how you want minizip packaged?

joebonrichie added a subscriber: joebonrichie.EditedSep 13 2017, 10:33 AM

Interested in getting this in for Chromium

Check the contents of zlib and zlib-devel if you still aren't sure

package.yml
20–23

It would be something like this:

- minizip:
    - /usr/lib64/libminizip.so.*
- minizip-devel:
    - /usr/include/minizip/*
    - /usr/lib64/*.a
    - /usr/lib64/libminizip.so
    - /usr/lib64/pkgconfig/minizip.pc

Added chromium as a child dep as it bundles it's own zlib with minizip support, but ideally I would like the use the system library.

curantes updated this revision to Diff 2741.Oct 3 2017, 7:58 PM

split minizip to devel pattern as well according to pointers from @ikey

joebonrichie accepted this revision.Oct 27 2017, 9:55 PM
This revision is now accepted and ready to land.Oct 27 2017, 9:55 PM
This revision was automatically updated to reflect the committed changes.