Page MenuHomeSolus

Initial inclusion of geeqie
ClosedPublic

Authored by algent on Dec 5 2019, 10:01 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Maniphest Tasks
T5942: Geeqie
Commits
R4885:4544cd87e16b: Initial inclusion of geeqie
Summary

Geeqie is a lightweight image viewer for Linux, BSDs and compatibles.It can be used as a simple, fast, database-free image viewer, but equally it can be used to manage large collections of images.

Resolve T5942

Signed-off-by: Algent Albrahimi <algent@protonmail.com>

Test Plan
  • Open a few folders with images and browse images
  • Make pan view
  • Started a slideshow
  • Crop Images
  • Change Orientations, rotate, mirror and flip

Diff Detail

Repository
R4885 geeqie
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

algent created this revision.Dec 5 2019, 10:01 PM
algent requested review of this revision.Dec 5 2019, 10:01 PM
JoshStrobl requested changes to this revision.Dec 6 2019, 10:19 AM
JoshStrobl added a subscriber: JoshStrobl.

Honestly I'd just disable the generation of documentation compiling. Most people are probably going to use the online help anyways.

This revision now requires changes to proceed.Dec 6 2019, 10:19 AM
algent updated this revision to Diff 18689.EditedDec 6 2019, 5:43 PM

Remove pkgconfig(gnome-doc-utils) and /usr/share/doc
but options "Help > Release Notes" and "Help > Changelog" will ask for files:
/usr/share/doc/geeqie-1.5.1/ChangeLog and /usr/share/doc/geeqie-1.5.1/README.md

Remove pkgconfig(gnome-doc-utils) and /usr/share/doc
but options "Help > Release Notes" and "Help > Changelog" will ask for files:
/usr/share/doc/geeqie-1.5.1/ChangeLog and /usr/share/doc/geeqie-1.5.1/README.md

Try the provided patch:

algent updated this revision to Diff 18836.Dec 16 2019, 7:40 PM

Add patch to remove Help and Changelog references to doc

Thank you @JoshStrobl for the patch, and sorry for late reply, I had some issues with email notifications.

Can you confirm that the patch did indeed work? I didn't test it :P

That patch you provided wasn't working, so I made a new one and deleted same lines.

JoshStrobl accepted this revision.Jan 10 2020, 5:30 PM

LGTM, thanks! Sorry for delayed patch review.

This revision is now accepted and ready to land.Jan 10 2020, 5:30 PM
This revision was automatically updated to reflect the committed changes.