Page MenuHomeSolus

Update libTAS to 1.3.5
ClosedPublic

Authored by serebit on Nov 29 2019, 5:35 PM.

Details

Summary
  • Hook Xinerama for games gathering the monitor resolution
  • Detect Windows executable and transparently call wine on it
  • Prevent the game screen from appearing unresponsive when the game is paused
  • Prevent monitor resolution change
  • Prevent game window from staying on top

Full changelog can be viewed here.

Test Plan

Created a short TAS for Chocolate DOOM

Diff Detail

Repository
R4702 libTAS
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

serebit created this revision.Nov 29 2019, 5:35 PM
serebit requested review of this revision.Nov 29 2019, 5:35 PM
JoshStrobl requested changes to this revision.Dec 4 2019, 8:43 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
24

Why is a development package being added as a runtime dependency for a tool?

26

Gonna be honest, their icon is dreadful and I think we should be replacing their libTAS Icon= in the desktop file with preferences-desktop-gaming instead.

29

We already have a %reconfigure macro that does all this.

This revision now requires changes to proceed.Dec 4 2019, 8:43 AM
serebit updated this revision to Diff 18645.Dec 4 2019, 1:36 PM
serebit marked an inline comment as done.
  • Use reconfigure macro
package.yml
24

Installing ffmpeg-devel fixed a symbol lookup issue in a particular game. I'm not sure how that makes sense either, and I'll retest later to see if it's actually necessary to fix the problem.

26

I agree, it is... kind of terrible. I'll patch the desktop file later today.

serebit marked 2 inline comments as not done.Dec 4 2019, 1:38 PM
serebit marked an inline comment as done.Dec 8 2019, 7:51 PM
serebit added inline comments.
package.yml
24

Retested, and Super Meat Boy crashes libTAS with an symbol lookup error on symbol swr_alloc if ffmpeg-devel isn't installed.

serebit updated this revision to Diff 18715.Dec 8 2019, 7:55 PM
  • Replace icon with preferences-desktop-gaming
serebit marked an inline comment as done.Dec 8 2019, 7:55 PM
JoshStrobl added inline comments.Dec 10 2019, 12:55 PM
package.yml
24

swr_alloc is exported by libswresample.so.3 which is in ffmpeg, not ffmpeg-devel. If it's happening only for a specific game then sounds like it's more an issue with the game than libTAS.

serebit added inline comments.Feb 2 2020, 12:22 AM
package.yml
24

Chocolate DOOM produces the same lookup error without the devel package installed, which leads me to believe it's either intended by libTAS or an issue with libTAS. I can put up an issue on the GitHub repo if you'd like me to investigate further.

JoshStrobl added inline comments.Apr 8 2020, 4:25 PM
package.yml
24

It's possible for whatever reason they're specifically wanting the SOs from ffmpeg-devel. If you do libsplit: no in ffmpeg does it resolve it?

serebit added inline comments.Apr 8 2020, 5:33 PM
package.yml
24

It does indeed resolve it. Rebuilt ffmpeg with that flag, installed it, uninstalled ffmpeg-devel, rebuilt libTAS, and it ran perfectly. I also made sure that it still wasn't working with the repository's version of ffmpeg.

JoshStrobl added inline comments.
package.yml
24

Alright, I'll go ahead and set libsplit: no on the ffmpeg package (unless you still have the changes in git, in which case feel free to make sure it's rebased against Girt's openal-soft rebuild and submit a patch). Will wait until @Girtablulu is done with the openal-soft builds to get that landed, then we can land that update and this along with it.

serebit added inline comments.Apr 8 2020, 5:42 PM
package.yml
24

I'll let you handle the libsplit changes :) Thanks for the help!

JoshStrobl accepted this revision.Apr 8 2020, 6:40 PM
JoshStrobl added inline comments.
package.yml
24

No problem, thanks for validating :)

This revision is now accepted and ready to land.Apr 8 2020, 6:40 PM
JoshStrobl requested changes to this revision.Apr 8 2020, 6:51 PM

Hate to do this to ya but this was bumped by Girt when he was doing the SDL2 upgrades + rebuilds last month so this needs to be rebased >.<

This revision now requires changes to proceed.Apr 8 2020, 6:51 PM
serebit updated this revision to Diff 20652.Apr 8 2020, 7:02 PM

Rebase on Girtablulu's patch :p

JoshStrobl accepted this revision.Apr 8 2020, 7:16 PM

Thanks!

This revision is now accepted and ready to land.Apr 8 2020, 7:16 PM
This revision was automatically updated to reflect the committed changes.