Page MenuHomeSolus

Update libTAS to 1.3.5
Needs ReviewPublic

Authored by serebit on Fri, Nov 29, 5:35 PM.

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Summary
  • Hook Xinerama for games gathering the monitor resolution
  • Detect Windows executable and transparently call wine on it
  • Prevent the game screen from appearing unresponsive when the game is paused
  • Prevent monitor resolution change
  • Prevent game window from staying on top

Full changelog can be viewed here.

Test Plan

Created a short TAS for Chocolate DOOM

Diff Detail

Repository
R4702 libTAS
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

serebit created this revision.Fri, Nov 29, 5:35 PM
serebit requested review of this revision.Fri, Nov 29, 5:35 PM
JoshStrobl requested changes to this revision.Wed, Dec 4, 8:43 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
24

Why is a development package being added as a runtime dependency for a tool?

26

Gonna be honest, their icon is dreadful and I think we should be replacing their libTAS Icon= in the desktop file with preferences-desktop-gaming instead.

29

We already have a %reconfigure macro that does all this.

This revision now requires changes to proceed.Wed, Dec 4, 8:43 AM
serebit updated this revision to Diff 18645.Wed, Dec 4, 1:36 PM
serebit marked an inline comment as done.
  • Use reconfigure macro
package.yml
24

Installing ffmpeg-devel fixed a symbol lookup issue in a particular game. I'm not sure how that makes sense either, and I'll retest later to see if it's actually necessary to fix the problem.

26

I agree, it is... kind of terrible. I'll patch the desktop file later today.

serebit marked 2 inline comments as not done.Wed, Dec 4, 1:38 PM