Paths

Table of Contentst

Differential D7670

Update python-colorlog to 4.0.2
ClosedPublic
Actions

Authored by algent on Nov 18 2019, 6:17 PM.

Tags

None

Referenced Files

	F11070576: D7670.diff
	Sat, Aug 12, 12:31 AM

	F11068444: D7670.diff
	Fri, Aug 11, 9:47 PM

	F10768195: D7670.id18408.diff
	May 20 2023, 4:54 AM

	F10761012: D7670.id.diff
	May 18 2023, 5:19 AM

	F10749959: D7670.id18408.diff
	May 16 2023, 5:18 AM

	F10749894: D7670.id18556.diff
	May 16 2023, 4:49 AM

	F10749697: D7670.diff
	May 16 2023, 3:21 AM

	F10735184: D7670.id.diff
	May 12 2023, 11:53 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

R3668:f8ade909a44f: Update python-colorlog to 4.0.2

Summary

Removed python2. This is a rundependency only for rapid-photo-downloader.

Summarized changelog:

TTYColoredFormatter requires the stream argument, avoiding checking the wrong stream and still displaying colors when it shouldn't.
Remove Python 2 only features. This removed the use of parse_colors directly in format strings, as it relied on an implementation specific detail of Python 2 and was broken on Python 3 (i.e. setting missing on an object's dict). It also adds some usage examples.
Various minor bug fixes and improvements.

Signed-off-by: Algent Albrahimi <algent@protonmail.com>

Test Plan

Run rapid-photo-downloader.

Diff Detail

Repository

R3668 python-colorlog

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

algent created this revision.Nov 18 2019, 6:17 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptNov 18 2019, 6:17 PM

algent requested review of this revision.Nov 18 2019, 6:17 PM

You need to be using the Phabricator stack functionality to indicate that the rapid-photo-downloader patch requires these updates.

This revision now requires changes to proceed.Nov 21 2019, 1:33 PM

algent added a child revision: D7673: Update rapid-photo-downloader to 0.9.17.Nov 21 2019, 3:25 PM

Added to the stack as rapid-photo-downloader dependency.

LGTM, thanks!

This revision is now accepted and ready to land.Nov 29 2019, 1:40 AM

Closed by commit R3668:f8ade909a44f: Update python-colorlog to 4.0.2 (authored by algent, committed by JoshStrobl). · Explain WhyNov 29 2019, 1:46 AM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R3668:f8ade909a44f: Update python-colorlog to 4.0.2.

Revision Contents
Changeset List

Path

Size

10 lines

pspec_x86_64.xml

53 lines

Diff 18556

package.yml

Loading...

pspec_x86_64.xml

Loading...