Page MenuHomeSolus

Update python-colorlog to 4.0.2
ClosedPublic

Authored by algent on Mon, Nov 18, 6:17 PM.

Details

Summary

Removed python2. This is a rundependency only for rapid-photo-downloader.

Summarized changelog:

  • TTYColoredFormatter requires the stream argument, avoiding checking the wrong stream and still displaying colors when it shouldn't.
  • Remove Python 2 only features. This removed the use of parse_colors directly in format strings, as it relied on an implementation specific detail of Python 2 and was broken on Python 3 (i.e. setting missing on an object's dict). It also adds some usage examples.
  • Various minor bug fixes and improvements.

Signed-off-by: Algent Albrahimi <algent@protonmail.com>

Test Plan

Run rapid-photo-downloader.

Diff Detail

Repository
R3668 python-colorlog
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

algent created this revision.Mon, Nov 18, 6:17 PM
algent requested review of this revision.Mon, Nov 18, 6:17 PM
JoshStrobl requested changes to this revision.Thu, Nov 21, 1:33 PM
JoshStrobl added a subscriber: JoshStrobl.

You need to be using the Phabricator stack functionality to indicate that the rapid-photo-downloader patch requires these updates.

This revision now requires changes to proceed.Thu, Nov 21, 1:33 PM
algent requested review of this revision.Thu, Nov 21, 3:30 PM

Added to the stack as rapid-photo-downloader dependency.

JoshStrobl accepted this revision.Fri, Nov 29, 1:40 AM

LGTM, thanks!

This revision is now accepted and ready to land.Fri, Nov 29, 1:40 AM
This revision was automatically updated to reflect the committed changes.