Differential D7670

Update python-colorlog to 4.0.2
ClosedPublic
Actions

Authored by algent on Mon, Nov 18, 6:17 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

R3668:f8ade909a44f: Update python-colorlog to 4.0.2

Summary

Removed python2. This is a rundependency only for rapid-photo-downloader.

Summarized changelog:

TTYColoredFormatter requires the stream argument, avoiding checking the wrong stream and still displaying colors when it shouldn't.
Remove Python 2 only features. This removed the use of parse_colors directly in format strings, as it relied on an implementation specific detail of Python 2 and was broken on Python 3 (i.e. setting missing on an object's dict). It also adds some usage examples.
Various minor bug fixes and improvements.

Signed-off-by: Algent Albrahimi <algent@protonmail.com>

Test Plan

Run rapid-photo-downloader.

Diff Detail

Repository

R3668 python-colorlog

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

algent created this revision.Mon, Nov 18, 6:17 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptMon, Nov 18, 6:17 PM

algent requested review of this revision.Mon, Nov 18, 6:17 PM

You need to be using the Phabricator stack functionality to indicate that the rapid-photo-downloader patch requires these updates.

This revision now requires changes to proceed.Thu, Nov 21, 1:33 PM

algent added a child revision: D7673: Update rapid-photo-downloader to 0.9.17.Thu, Nov 21, 3:25 PM

Added to the stack as rapid-photo-downloader dependency.

LGTM, thanks!

This revision is now accepted and ready to land.Fri, Nov 29, 1:40 AM

Closed by commit R3668:f8ade909a44f: Update python-colorlog to 4.0.2 (authored by algent, committed by JoshStrobl). · Explain WhyFri, Nov 29, 1:46 AM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R3668:f8ade909a44f: Update python-colorlog to 4.0.2.

Revision Contents
Changeset List

			Path	Packages
M			package.yml (10 lines)
M			pspec_x86_64.xml (53 lines)

Diff 18556

package.yml

Loading...

pspec_x86_64.xml

Loading...