Page MenuHomeSolus
Differential D7662

Update neovim to 0.4.3
ClosedPublic
Actions

Authored by JamesLee on Nov 17 2019, 8:58 PM.
Tags
None
Referenced Files
F11033637: D7662.id18628.diff
Wed, Aug 9, 3:54 PM
F11033636: D7662.id.diff
Wed, Aug 9, 3:54 PM
F11033635: D7662.id18602.diff
Wed, Aug 9, 3:54 PM
F11033634: D7662.id18372.diff
Wed, Aug 9, 3:54 PM
F11033633: D7662.id18370.diff
Wed, Aug 9, 3:54 PM
F11026173: D7662.diff
Wed, Aug 9, 1:58 AM
F11015693: D7662.diff
Sat, Aug 5, 1:33 PM
F10944052: D7662.id18602.diff
Fri, Jul 14, 10:02 PM
View All 17 Files
Subscribers
ermo
JoshStrobl

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R2148:cd38a88d05d1: Update neovim to 0.4.3
Summary

Updated Neovim to the latest stable release 0.4.3.

Depends on D7658, D7659, D7660, D7661

Changelogs:

Test Plan
  • Installed and ran ':checkhealth' with everything working as expected
  • Ran with my own 'init.vim' with everything working as expected

Diff Detail

Repository
R2148 neovim
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

JamesLee created this revision.Nov 17 2019, 8:58 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptNov 17 2019, 8:58 PM
JamesLee requested review of this revision.Nov 17 2019, 8:58 PM
JamesLee edited the summary of this revision. (Show Details)Nov 17 2019, 9:00 PM
JamesLee added parent revisions: D7661: Update unibilium to 2.0.0, D7660: Update libvterm to 0.1.2, D7659: Update libtermkey to 0.20, D7658: Initial packaging of libluv at version 1.32.0.
ermo added a subscriber: ermo.Nov 17 2019, 10:45 PM

Did you already take a look at the pkgconfig file of libluv?

package.yml
21

It looks like libluv contains a pkgconfig file? Does that not work?

See line #41 of the libluv pspec_x86_64.xml file.

JamesLee updated this revision to Diff 18372.Nov 17 2019, 10:54 PM

I had tried using pkg-config to no avail; as it turns out, I just spelt
'libluv' incorrectly... I've updated the patch to use pkg-config.

JoshStrobl requested changes to this revision.Nov 21 2019, 1:44 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
12

They removed the requirement of jemalloc so let's remove the pkgconfig.

This revision now requires changes to proceed.Nov 21 2019, 1:44 PM
JamesLee updated this revision to Diff 18602.Nov 30 2019, 5:38 PM

Removed unnecessary 'jemalloc' requirement

JoshStrobl accepted this revision.Dec 4 2019, 7:41 AM

LGTM, thanks!

This revision is now accepted and ready to land.Dec 4 2019, 7:41 AM
Closed by commit R2148:cd38a88d05d1: Update neovim to 0.4.3 (authored by JamesLee, committed by JoshStrobl). · Explain WhyDec 4 2019, 7:47 AM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R2148:cd38a88d05d1: Update neovim to 0.4.3.

Revision Contents
Changeset List

PathSize
6 lines
7 lines
32 lines

Diff 18372

View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.