Page MenuHomeSolus
Differential D7658

Initial packaging of libluv at version 1.32.0
ClosedPublic
Actions

Authored by JamesLee on Nov 17 2019, 8:45 PM.
Tags
None
Referenced Files
F11033649: D7658.id18601.diff
Wed, Aug 9, 3:54 PM
F11033648: D7658.id18366.diff
Wed, Aug 9, 3:54 PM
F11033647: D7658.id18624.diff
Wed, Aug 9, 3:54 PM
F11033645: D7658.id.diff
Wed, Aug 9, 3:54 PM
F11033644: D7658.id18371.diff
Wed, Aug 9, 3:54 PM
F11026176: D7658.diff
Wed, Aug 9, 1:59 AM
F11019913: D7658.id.diff
Sun, Aug 6, 11:43 PM
F10988962: D7658.diff
Mon, Jul 24, 1:09 PM
View All 20 Files
Subscribers
Girtablulu
JoshStrobl

Details

Reviewers
JoshStrobl
Group Reviewers
Triage Team
Commits
R4868:c88685b4b6b6: Initial packaging of libluv at version 1.32.0
Summary

Packaged libluv at version 1.32.0 as a requirement for Neovim 0.4.3

Test Plan
  • Used to build the latest version of Neovim
  • Installed alongside Neovim 0.3.4 with everything working as expected

Diff Detail

Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

JamesLee created this revision.Nov 17 2019, 8:45 PM
Herald added a reviewer: Triage Team. · View Herald TranscriptNov 17 2019, 8:45 PM
JamesLee requested review of this revision.Nov 17 2019, 8:45 PM
JamesLee mentioned this in D7662: Update neovim to 0.4.3.Nov 17 2019, 8:58 PM
JamesLee added a child revision: D7662: Update neovim to 0.4.3.Nov 17 2019, 9:00 PM
Girtablulu added a subscriber: Girtablulu.Nov 17 2019, 10:32 PM

We do have a ninja makro

https://getsol.us/articles/packaging/package.yml/en/

JamesLee updated this revision to Diff 18371.EditedNov 17 2019, 10:38 PM

Apparently I missed the ninja macros, updated the patch to utilise them

JoshStrobl requested changes to this revision.Nov 21 2019, 1:39 PM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
19

This is already specified in our rc.yml for this macro: https://github.com/getsolus/ypkg/blob/master/ypkg2/rc.yml#L18

This revision now requires changes to proceed.Nov 21 2019, 1:39 PM
JamesLee updated this revision to Diff 18601.Nov 30 2019, 5:36 PM

Removed unnecessary install prefix

JoshStrobl accepted this revision.Dec 4 2019, 7:41 AM

LGTM, thanks!

This revision is now accepted and ready to land.Dec 4 2019, 7:41 AM
Closed by commit R4868:c88685b4b6b6: Initial packaging of libluv at version 1.32.0 (authored by JamesLee, committed by JoshStrobl). · Explain WhyDec 4 2019, 7:42 AM
This revision was automatically updated to reflect the committed changes.
JoshStrobl added a commit: R4868:c88685b4b6b6: Initial packaging of libluv at version 1.32.0.

Revision Contents
Changeset List

PathSize
1 line
10 lines
2 lines
25 lines
53 lines

Diff 18366

View Options

Makefile

Loading...
View Options

abi_symbols

Loading...
View Options

abi_used_libs

Loading...
View Options

package.yml

Loading...
View Options

pspec_x86_64.xml

Loading...
Copyright © 2015-2021 Solus Project. The Solus logo is Copyright © 2016-2021 Solus Project. All Rights Reserved.