Paths

Table of Contentst

Differential D7639

Update fluidsynth to 2.0.9
ClosedPublic
Actions

Authored by kyrios123 on Nov 14 2019, 6:43 PM.

Tags

None

Referenced Files

	F11047635: D7639.diff
	Thu, Aug 10, 3:38 PM

	F10875909: D7639.id18318.diff
	Jun 20 2023, 8:07 AM

	F10873139: D7639.id18301.diff
	Jun 19 2023, 8:32 AM

	F10864234: D7639.diff
	Jun 17 2023, 7:07 AM

	F10791191: D7639.id18301.diff
	May 27 2023, 1:57 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

R773:606f0961be90: Update fluidsynth to 2.0.9

Summary

an implicitly declared function caused a pointer to int truncation in CoreAudio driver
fix a stack-based overflow in CoreAudio driver

Signed-off-by: Pierre-Yves <pyu@riseup.net>

Test Plan

Tested with qsynth

Diff Detail

Repository

R773 fluidsynth

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kyrios123 created this revision.Nov 14 2019, 6:43 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptNov 14 2019, 6:43 PM

kyrios123 requested review of this revision.Nov 14 2019, 6:43 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Nov 14 2019, 7:09 PM

Closed by commit R773:606f0961be90: Update fluidsynth to 2.0.9 (authored by kyrios123). · Explain WhyNov 14 2019, 7:54 PM

This revision was automatically updated to reflect the committed changes.

kyrios123 added a commit: R773:606f0961be90: Update fluidsynth to 2.0.9.

Just want to point out that there is a MAINTAINERS.md file in this repository...

In D7639#121948, @Jacalz wrote:

Just want to point out that there is a MAINTAINERS.md file in this repository...

And @kyrios123 is a member of the Global Maintainers who submitted a patch first. He probably should have paid a little more attention to that, but I doubt his intent was to step on toes. Would you rather I have rejected it after he already put in the work?

No, I just wanted to inform, but I can admit that the phrasing in my initial comment was less that optimal...

Apologize, I indeed missed the MAINTAINERS.md file, mea culpa.
I should update my script to add a check on this.

Revision Contents
Changeset List

Path

Size

8 lines

pspec_x86_64.xml

16 lines

Diff 18301

package.yml

Loading...

pspec_x86_64.xml

Loading...