Various improvements and cleanups in mpv
ClosedPublic
Actions

Authored by aleksvor on Nov 12 2019, 5:25 PM.

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Commits

R2107:fc1c9a284c73: Various improvements and cleanups in mpv

Summary

Packaging changes:

Cleaned up builddeps:
- Removed mpg123 - it wasn't used by mpv since 0.9.0 (see commit).
- Removed x11 - it's pulled in by other X11 dependencies.
- Changed some pkgconfigs to better show which libs are being used (gl -> gbm, libturbojpeg -> libjpeg, libva-x11 -> libva)
Switched to LuaJIT for better performance of Lua scripts and rewrote patch for bash completions accordingly.
Added rubberband support for high-quality pitch correction.

Test Plan

Watched VP9 video with X11 output.
Called built-in statistics script to test Lua support.

Diff Detail

Repository

R2107 mpv

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

aleksvor created this revision.Nov 12 2019, 5:25 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptNov 12 2019, 5:25 PM

aleksvor requested review of this revision.Nov 12 2019, 5:25 PM

Jacalz awarded a token.Nov 12 2019, 6:09 PM

Otherwise LGTM.

package.yml
19	Remove the caca support, thanks.

This revision now requires changes to proceed.Nov 12 2019, 10:27 PM

Removed caca support per review.
Fixed sorting order (libass and libarchive).

aleksvor edited the summary of this revision. (Show Details)Nov 14 2019, 6:47 AM

aleksvor edited the test plan for this revision. (Show Details)

Let's remove the maintainer file from this. Realistically it's something Core Team and Global Maintainers are also going to be making frequent changes and rebuilds of against stack changes.