Details
- Reviewers
DataDrake - Group Reviewers
Triage Team
Building Linux using Clang.
Linux version 5.3.9-135.current (root@prism) (clang version 9.0.0 (tags/RELEASE_900/final)) #1 SMP PREEMPT Sun Nov 10 00:01:53 EST 2019
Diff Detail
- Repository
- R1972 llvm
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Should this patch be accepted, we should add my Rust patch to the stack.
EDIT: this one D7599.
In addition to the circular dependency, your test plan is not sufficient. As the kernel maintainer, I have no interest in Clang builds at the moment, so that's not a valid test. As the mesalib maintainer, I will not accept this patch until you have rebuilt and tested mesalib against this. Given that only a few other packages directly link against LLVM and the number of affected users if they are broken, I also expect that you test them as well:
- beignet
- blender
- dolphin-emu
- ldc
- lldb
- mesalib
I hope that it’s not too much to ask for, but could this please be landed after D6460 to save me the whole problem with the rebasing my update after the LLVM-9 rebuild? @DataDrake
| package.yml | ||
|---|---|---|
| 13 | Better bump this up to https while you're at it :) | |
Updated to HTTPS, sorry about that!
Also I have compiled mesalib against this and it works fine.
When trying to build beignet it complains quite a bit. I tried the llvm9 patch from FreeBSD but still has some issues. I'm not informed enough to fix most issues with 9.0, so should I abandon it or leave it here in case someone else wants to continue on it?
Also, the license model changed for this version. It's now Apache License version 2.0 with llvm exception
I hate to step on your toes but i have had this upgrade done locally, with rebuilds done and tested, for a couple of weeks now. The only thing i've been waiting on is a new release of python-llvmlite which is why it hasn't been pushed yet (but, it looks like llvmlite can just be patched, as the issues are windows localized).