This patch is only needed to correctly build D7865 since Rust 1.38 cannot compile Rust 1.40.
Details
Details
- Reviewers
JoshStrobl - Group Reviewers
Triage Team - Commits
- R2839:813042e53152: Update rust to 1.39.0
Built ripgrep and Firefox successfully.
Diff Detail
Diff Detail
- Repository
- R2839 rust
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
I'm statically linking our LLVM. This leads to a slightly reduced package size (see T8434). If anyone familiar with LLVM can tell me that the toolchain doesn't break its ABI often, I could even link Rust dynamically against it to save even more space.
Comment Actions
This is fine with me. Eventually, to enable cross-lang PGO/LTO in firefox, both firefox and rust will need to link/use the same llvm/clang to maintain compatibility and reduce the risk of weird compiler mismatch errors. I think this is how you link it as a shared lib:
[llvm] link-shared = true
Comment Actions
@joebonrichie are you the LLVM maintainer? So that I know if your reply suffices or I have to wait for Core.