Page MenuHomeSolus

Update android-tools to 29.0.5
ClosedPublic

Authored by chax on Mon, Nov 4, 11:45 PM.

Details

Summary

Update android-tools to 29.0.5
Changes:

  • Slight performance improvement on Linux when using many simultaneous connections.
  • Add --fastdeploy option to adb install, for incremental updates to APKs while developing.
Test Plan

Built, installed and issued few adb and fastboot commands

Diff Detail

Repository
R4737 android-tools
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chax created this revision.Mon, Nov 4, 11:45 PM
chax requested review of this revision.Mon, Nov 4, 11:45 PM
JoshStrobl requested changes to this revision.Wed, Nov 6, 8:15 AM
JoshStrobl added a subscriber: JoshStrobl.
JoshStrobl added inline comments.
package.yml
33

Why is vim being added?

55

Why do we suddenly need this?

This revision now requires changes to proceed.Wed, Nov 6, 8:15 AM
chax added inline comments.Wed, Nov 6, 9:07 AM
package.yml
33

Part of vim is used for building. If you check generate_build.rb script, you will notice use of binary xxd which comes with vim package. It is needed to convert file to bytearray which gets included in source of adb tool.

55

This is new adb feature called fastdeploy. It works by uploading two files to your android phone on first run (deployagent.jar and deployagent.sh) and later it uses them to check from within the phone whether only the part of app needs to be updated and this way installing app via adb install becomes faster operation when you as an app developer incrementally update your app.

Shell script deployagent.sh is used to invoke deployagent.jar, and both of those files are included in adb binary by converting them to bytearray and including that in adb source.

We can build deployagent.jar from source but that requires installation of whole Android SDK and it would be too complicated to incorporate that in our build system. This way i just uploaded this pre-built file and it is used in build process. I actually didn't event build it myself, but i used official binary of adb and by using adb install --fastdeploy these files ended up on my phone and i just extracted deployagent.jar from my phone. The other file deployagent.sh shell script i use directly from android sources.

chax requested review of this revision.Wed, Nov 6, 10:26 AM

Added comments explaining addition of deployagent.jar, please re-review.

chax updated this revision to Diff 18223.Fri, Nov 8, 11:57 AM

download androidfw archive from getsol.us/sources

chax updated this revision to Diff 18224.Fri, Nov 8, 12:07 PM

added comment about where is original androidfw archive downloaded from

JoshStrobl requested changes to this revision.Sat, Nov 9, 5:18 AM

Other than that, LGTM.

package.yml
34

We don't need wget as a builddep anymore.

This revision now requires changes to proceed.Sat, Nov 9, 5:18 AM
chax added inline comments.Sat, Nov 9, 7:19 AM
package.yml
34

forgot to remove it

chax updated this revision to Diff 18233.Sat, Nov 9, 7:22 AM

remove wget as builddep

JoshStrobl accepted this revision.Fri, Nov 15, 1:14 PM

Not the biggest fan of the jar file but also don't think it's reasonable to require all of the SDK just for it so going to mark as accepted. Thanks for the patch.

This revision is now accepted and ready to land.Fri, Nov 15, 1:14 PM
This revision was automatically updated to reflect the committed changes.