Page MenuHomeSolus

Update git to 2.24.0
Needs ReviewPublic

Authored by chax on Mon, Nov 4, 12:32 PM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Summary

Changelog can be found here

Test Plan
  • Unit tests passed
  • This patch was submitted with git 2.24.0

Diff Detail

Repository
R909 git
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

chax created this revision.Mon, Nov 4, 12:32 PM
chax requested review of this revision.Mon, Nov 4, 12:32 PM
DataDrake requested changes to this revision.Wed, Nov 6, 8:03 AM
DataDrake added a subscriber: DataDrake.
DataDrake added inline comments.
abi_used_libs
16

Uhhhhhh. Wat. Kinda need ssh for anything useful. Are you missing a flag?

This revision now requires changes to proceed.Wed, Nov 6, 8:03 AM
chax added inline comments.Wed, Nov 6, 8:46 AM
abi_used_libs
16

i will check, it seemed strange to me also, why all of these abi libs were removed, but i changed nothing but version and tar.

chax added inline comments.Wed, Nov 6, 10:52 AM
abi_used_libs
16

some of these dependencies that are removed are also dependency of libcurl (libssh is one of them), so they will indirectly be dependency of git also.
I can upload build log so you can see that solbuilds determine these dependencies are no longer needed (not directly that is).

chax added a comment.Wed, Nov 6, 11:22 AM

This is the buildlog for previous version on our build server: https://build.getsol.us/logs/git-2.23.0-85.log.gz
This is the buildlog from my local build: (i split it into three files so they can be uploaded to termbin.com):

chax requested review of this revision.Wed, Nov 6, 11:22 AM
joebonrichie added inline comments.
abi_used_libs
16

Some places in the stack where LD_AS_NEEDED was set to false and is now true causes these large knock on affect for rebuilds, as I understand.