Differential D7567

Update git to 2.24.0
ClosedPublic
Actions

Authored by chax on Nov 4 2019, 12:32 PM.

Tags

None

Subscribers

joebonrichie, DataDrake

Details

Reviewers

Group Reviewers

Commits

R909:1b214c06b068: Update git to 2.24.0

Summary

Changelog can be found here

Test Plan

Unit tests passed
This patch was submitted with git 2.24.0

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chax created this revision.Nov 4 2019, 12:32 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptNov 4 2019, 12:32 PM

chax requested review of this revision.Nov 4 2019, 12:32 PM

DataDrake requested changes to this revision.Nov 6 2019, 8:03 AM

DataDrake added a subscriber: DataDrake.

DataDrake added inline comments.

abi_used_libs
16	Uhhhhhh. Wat. Kinda need ssh for anything useful. Are you missing a flag?

This revision now requires changes to proceed.Nov 6 2019, 8:03 AM

chax added inline comments.Nov 6 2019, 8:46 AM

abi_used_libs
16	i will check, it seemed strange to me also, why all of these abi libs were removed, but i changed nothing but version and tar.

chax added inline comments.Nov 6 2019, 10:52 AM

abi_used_libs
16	some of these dependencies that are removed are also dependency of libcurl (libssh is one of them), so they will indirectly be dependency of git also. I can upload build log so you can see that solbuilds determine these dependencies are no longer needed (not directly that is).

This is the buildlog for previous version on our build server: https://build.getsol.us/logs/git-2.23.0-85.log.gz
This is the buildlog from my local build: (i split it into three files so they can be uploaded to termbin.com):

chax requested review of this revision.Nov 6 2019, 11:22 AM

joebonrichie added a subscriber: joebonrichie.Nov 6 2019, 2:47 PM

joebonrichie added inline comments.

abi_used_libs
16	Some places in the stack where LD_AS_NEEDED was set to false and is now true causes these large knock on affect for rebuilds, as I understand.

chax mentioned this in D7584: Update curl to 7.67.0.Nov 7 2019, 8:34 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Nov 18 2019, 5:15 AM

Closed by commit R909:1b214c06b068: Update git to 2.24.0 (authored by chax, committed by DataDrake). · Explain WhyNov 18 2019, 5:22 AM

This revision was automatically updated to reflect the committed changes.

DataDrake added a commit: R909:1b214c06b068: Update git to 2.24.0.

Revision Contents
Changeset List

			Path	Packages
M			abi_used_libs (7 lines)
M			package.yml (6 lines)
M			pspec_x86_64.xml (16 lines)

Diff 18375

abi_used_libs

Loading...

package.yml

Loading...

pspec_x86_64.xml

Loading...