If this change is required for your podman update, please ensure you use Phabricator's stack feature. No explanation was also given as to why conmon is being added into that podman path either, or if that's a symlink to /usr/bin/conmon (and if not, why isn't it?)

This revision now requires changes to proceed.Wed, Nov 6, 7:46 AM

it is not required by podman, but it is recommended. Podman will search for conmon first in libexec path, if it doesn't find it there, then it search it in few other predefined locations, and lastly it looks in PATH. So, this is just a bonus, if you think this is unnecessary, can remove 'podman' from %make_install command.

It's a copy and not symlink in libexec, so. I will remove it because it is unnecessary.

removed libexec copy of conmon binary

chax added a child revision: D7558: Update podman to 1.6.3.Wed, Nov 6, 9:56 AM

chax added a child revision: D7559: Update buildah to 1.11.4.Wed, Nov 6, 10:21 AM

chax removed a child revision: D7559: Update buildah to 1.11.4.

LGTM, thanks!

This revision is now accepted and ready to land.Fri, Nov 8, 9:48 AM

Closed by commit R4786:89b11b95c9f2: Update conmon to 2.0.2 (authored by chax, committed by JoshStrobl). · Explain WhyFri, Nov 8, 10:05 AM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R4786:89b11b95c9f2: Update conmon to 2.0.2.

Revision Contents
Changeset List

			Path	Packages
M			package.yml (10 lines)
M			pspec_x86_64.xml (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	18123	3094ad4		Sat, Nov 2, 2:50 PM	★	★
Diff 2	18178	3094ad4	removed libexec copy of conmon binary	Wed, Nov 6, 9:45 AM	★	★
Diff 3	18219	3094ad4	R4786:89b11b95c9f2f5cd01924f9e3d3aa54e471e743d	Fri, Nov 8, 10:04 AM	★	★

Update conmon to 2.0.2ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 18219

package.yml

pspec_x86_64.xml

Update conmon to 2.0.2
ClosedPublic
Actions

Revision Contents
Changeset List