Page MenuHomeSolus

Update conmon to 2.0.2

Authored by chax on Nov 2 2019, 2:50 PM.



Update conmon to 2.0.2
This is minor release with minor bug fixes and improvements.

Test Plan

Tested through podman.

Diff Detail

R4786 conmon
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chax created this revision.Nov 2 2019, 2:50 PM
chax requested review of this revision.Nov 2 2019, 2:50 PM
JoshStrobl requested changes to this revision.Nov 6 2019, 7:46 AM
JoshStrobl added a subscriber: JoshStrobl.

If this change is required for your podman update, please ensure you use Phabricator's stack feature. No explanation was also given as to why conmon is being added into that podman path either, or if that's a symlink to /usr/bin/conmon (and if not, why isn't it?)

This revision now requires changes to proceed.Nov 6 2019, 7:46 AM
chax added a comment.Nov 6 2019, 8:43 AM

it is not required by podman, but it is recommended. Podman will search for conmon first in libexec path, if it doesn't find it there, then it search it in few other predefined locations, and lastly it looks in PATH. So, this is just a bonus, if you think this is unnecessary, can remove 'podman' from %make_install command.

chax added a comment.EditedNov 6 2019, 9:42 AM

It's a copy and not symlink in libexec, so. I will remove it because it is unnecessary.

chax updated this revision to Diff 18178.Nov 6 2019, 9:45 AM

removed libexec copy of conmon binary

JoshStrobl accepted this revision.Nov 8 2019, 9:48 AM

LGTM, thanks!

This revision is now accepted and ready to land.Nov 8 2019, 9:48 AM
This revision was automatically updated to reflect the committed changes.