Page MenuHomeSolus

Initial inclusion of chiaki
ClosedPublic

Authored by tarkah on Oct 29 2019, 4:50 PM.

Details

Summary

Resolves T8455

Test Plan

I have built and run locally, successfully connected to my ps4, and played through a few games without issue using DS4 controller connected via bluetooth.

Diff Detail

Repository
R4939 chiaki
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tarkah created this revision.Oct 29 2019, 4:50 PM
tarkah requested review of this revision.Oct 29 2019, 4:50 PM
tarkah edited the summary of this revision. (Show Details)Oct 29 2019, 4:53 PM
Girtablulu abandoned this revision.Oct 29 2019, 5:28 PM
Girtablulu added a subscriber: Girtablulu.

Before a package will be accepted into the repo and inclusion task has to be created, should it be accepted then someone can package it

https://getsol.us/articles/packaging/request-a-package/en/

Gotcha, I got ahead of myself. Let me submit a task.

no problems, on a first glance your package.yml looks good

tarkah updated this revision to Diff 19698.Feb 12 2020, 1:08 AM

Bump to latest version

JoshStrobl requested changes to this revision.Feb 12 2020, 1:19 AM
JoshStrobl added a subscriber: JoshStrobl.

builddeps should also be alphabetically sorted with pkgconfigs first, then explicit packages. Also either you're missing the abi_* files, or the binary doesn't link against anything, in which case you would need to add items like qt5-svg as a rundep.

package.yml
15

Not needed, this is a dependency of qt5-svg-devel

18

Not needed, this is part of system.devel component which is always in the solbuild image.

19

Is this a runtime dependency? If so, it needs to be listed under rundeps, similar to builddeps, because it isn't something that gets linked to a library or a binary.

This revision now requires changes to proceed.Feb 12 2020, 1:19 AM
This comment was removed by tarkah.
tarkah added inline comments.Feb 12 2020, 5:23 PM
package.yml
15

That's correct, I've removed and build works

18

Makes sense, removed

19

I don't think so, package source has this note:

protoc and the protobuf Python library (only used during compilation for Nanopb)

I don't have it installed and the package runs fine on every feature.

tarkah updated this revision to Diff 19729.Feb 12 2020, 5:26 PM

Remove unneeded deps and reorder deps

@JoshStrobl thanks for the helpful feedback! There wasn't any abi_* files, however the build output shows the following dependencies. I made the other changes above.

[Build] install successful
[Examine] Examining packages
[Stripped] /usr/bin/chiaki
[Dependency] /usr/bin/chiaki adds dependency on libQt5Svg.so.5 from qt5-svg
[Dependency] /usr/bin/chiaki adds dependency on libavcodec.so.58 from ffmpeg
[Dependency] /usr/bin/chiaki adds dependency on libstdc++.so.6 from libstdc++
[Dependency] /usr/bin/chiaki adds dependency on libcrypto.so.1.0.0 from openssl
[Dependency] /usr/bin/chiaki adds dependency on libQt5Multimedia.so.5 from qt5-multimedia                                                         
[Dependency] /usr/bin/chiaki adds dependency on libopus.so.0 from opus                                                                            
[Dependency] /usr/bin/chiaki adds dependency on libSDL2-2.0.so.0 from sdl2                                                                        
[Dependency] /usr/bin/chiaki adds dependency on libavutil.so.56 from ffmpeg                                                                       
[Dependency] /usr/bin/chiaki adds dependency on libgcc_s.so.1 from libgcc                                                                         
[Dependency] /usr/bin/chiaki adds dependency on libpthread.so.0 from glibc                                                                        
[Dependency] /usr/bin/chiaki adds dependency on libQt5Core.so.5 from qt5-base                                                                     
[Dependency] /usr/bin/chiaki adds dependency on libQt5Widgets.so.5 from qt5-base                                                                  
[Dependency] /usr/bin/chiaki adds dependency on libc.so.6 from glibc                                                                              
[Dependency] /usr/bin/chiaki adds dependency on libQt5Gui.so.5 from qt5-base
[Package] Creating /home/build/work/chiaki-1.1.3-1-1-x86_64.eopkg ...
[Package] Building complete                                                                                                                       
INFO[09:35:10] Building succeeded
algent added a subscriber: algent.Feb 12 2020, 6:17 PM

There should be abi_used_libs .
I copied your package.yml and build it in my PC. There was generated abi_used_libs with the content below.

$ cat abi_used_libs 
libQt5Core.so.5
libQt5Gui.so.5
libQt5Multimedia.so.5
libQt5Svg.so.5
libQt5Widgets.so.5
libSDL2-2.0.so.0
libavcodec.so.58
libavutil.so.56
libc.so.6
libcrypto.so.1.0.0
libgcc_s.so.1
libopus.so.0
libpthread.so.0
libstdc++.so.6

It is strange why you don't have it.

Huh, that's so weird... I'll play around to see if I can get it to output after the build, otherwise I'll just manually add the output you listed. Thanks, @algent!

Ahh, I was manually running sudo solbuild build package.yml -p unstable-x86_64. When I tried with make, it ran the abireport.

tarkah updated this revision to Diff 19731.Feb 12 2020, 6:51 PM

Add abi_used_libs file

JoshStrobl accepted this revision.Apr 8 2020, 4:21 PM

LGTM otherwise!

package.yml
12

pkgconfigs should be listed as A-Za-z order

This revision is now accepted and ready to land.Apr 8 2020, 4:21 PM
JoshStrobl requested changes to this revision.Apr 8 2020, 4:21 PM

Derp.

This revision now requires changes to proceed.Apr 8 2020, 4:21 PM
tarkah updated this revision to Diff 20647.EditedApr 8 2020, 4:47 PM

Updated, thanks!

tarkah marked an inline comment as done.Apr 8 2020, 4:47 PM
JoshStrobl accepted this revision.Apr 8 2020, 4:49 PM
JoshStrobl retitled this revision from Add Chiaki package to Initial inclusion of chiaki.
JoshStrobl edited the summary of this revision. (Show Details)

LGTM, thanks!

This revision is now accepted and ready to land.Apr 8 2020, 4:50 PM
This revision was automatically updated to reflect the committed changes.