Fix broken symlink
ClosedPublic
Actions

Authored by Jacalz on Oct 28 2019, 8:01 AM.

Tags

None

Referenced Files

	F11053496: D7515.id18069.diff
	Thu, Aug 10, 11:20 PM

	F11053495: D7515.id18019.diff
	Thu, Aug 10, 11:20 PM

	F11053494: D7515.id.diff
	Thu, Aug 10, 11:20 PM

	F11053493: D7515.id18047.diff
	Thu, Aug 10, 11:20 PM

	F11037835: D7515.diff
	Wed, Aug 9, 9:19 PM

	F10977145: D7515.id18069.diff
	Sat, Jul 22, 2:10 PM

	F10823942: D7515.id.diff
	Jun 3 2023, 9:32 AM

	F10807783: D7515.id18069.diff
	May 30 2023, 6:06 AM

View All 12 Files

Subscribers

JoshStrobl

Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Commits

R4741:4a6916eab88d: Fix broken symlink

Summary

The symlink was accidentally pointed at the contrainer and ot the real world place.

Test Plan

Play with the symlink in sf2 player in LMMS.

Diff Detail

Repository

R4741 fluid-soundfont

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Jacalz created this revision.Oct 28 2019, 8:01 AM

Herald added a reviewer: Triage Team. · View Herald TranscriptOct 28 2019, 8:01 AM

Jacalz requested review of this revision.Oct 28 2019, 8:01 AM

Jacalz mentioned this in T8427: fluid-soundfont has a different file name.Oct 28 2019, 8:02 AM

JoshStrobl requested changes to this revision.Oct 28 2019, 11:05 PM

JoshStrobl added a subscriber: JoshStrobl.

JoshStrobl added inline comments.

package.yml
14	This needs to be fixed. Should be : \| Was this not generated using our package.yml generation?

This revision now requires changes to proceed.Oct 28 2019, 11:05 PM

Make sure that the description is correct.

package.yml
14	I will be honest and say that I didn't know that it existed back when I wrote this package. :I

Well LGTM now, thank you for the fix.

This revision is now accepted and ready to land.Nov 1 2019, 9:44 AM

Closed by commit R4741:4a6916eab88d: Fix broken symlink (authored by Jacalz, committed by JoshStrobl). · Explain WhyNov 1 2019, 9:44 AM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R4741:4a6916eab88d: Fix broken symlink.

Revision Contents
Changeset List

Path

Size

package.yml

22 lines

pspec_x86_64.xml

14 lines

Diff 18069

View Options

package.yml

View Options

Fix broken symlinkClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 18069

package.yml

pspec_x86_64.xml

Fix broken symlink
ClosedPublic
Actions

Revision Contents
Changeset List