Page MenuHomeSolus

Update Gradle to 4.9
AcceptedPublic

Authored by serebit on Mon, Oct 28, 1:31 AM.

Details

Reviewers
DataDrake
Group Reviewers
Triage Team
Summary

Remove desktop file, as it's unnecessary for a primarily terminal-based program. Upgrade to the latest version that fully supports being built with JDK 8.

Test Plan

Build openjfx-8 and a moderately sized personal Gradle project

Diff Detail

Repository
R1050 gradle
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

serebit created this revision.Mon, Oct 28, 1:31 AM
serebit requested review of this revision.Mon, Oct 28, 1:31 AM
serebit added a comment.EditedMon, Oct 28, 1:43 AM

This is the newest version I could upgrade to without build errors due to various factors. Gradle versions past 4.9 either fail to compile without JDK 9+, or outright refuse to compile without JDK 9+. This Gradle update was necessary to upgrade OpenJFX 8.

DataDrake accepted this revision.Sun, Nov 10, 4:55 PM
DataDrake added a subscriber: DataDrake.

LGTM. Thanks!

This revision is now accepted and ready to land.Sun, Nov 10, 4:56 PM
serebit updated this revision to Diff 18343.Fri, Nov 15, 6:03 PM

Added bash completion from gradle-completion as per T8483