Differential D7511

Revert back to v3.7.3
AbandonedPublic
Actions

Authored by ZVNexus on Oct 27 2019, 9:14 PM.

Details

Reviewers

None

Group Reviewers

Triage Team

Summary

Causes issues while building AOSP with ccache enabled.

ld.lld: error: undefined symbol: strcpy_a9

Bonito shouldn't even be using ld.lld, so this is extremely
strange.

Test Plan

Recompile AOSP with no issue.

Diff Detail

Repository

R499 ccache

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ZVNexus created this revision.Oct 27 2019, 9:14 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptOct 27 2019, 9:14 PM

ZVNexus requested review of this revision.Oct 27 2019, 9:14 PM

This is still an upgrade to the version we were using prior, so semi revert I guess?

ZVNexus added a comment.Oct 27 2019, 11:02 PM

This comment was removed by ZVNexus.

Are you sure that this isn't a configuration issue for AOSP?

I can't be sure. What I do know is 3.7.5 causes AOSP builds to fail on Android 10 (doesn't seem to affect Android 9) and I don't know what in AOSP was added to cause this to occur. They stopped using ccache internally for their builds so it's not like they support it anymore, but many custom distributions re-enabled it as it's still useful to us. Clean builds without ccache take hours, not having ccache as an option is not that great. What we could do is update the AOSP build instructions to include it's own version of ccache that we put in PATH so the main package wouldn't need to be changed as this seems to only affect AOSP not any other packages I build with ccache. Although, I can't see any packages Solus builds having an issue going back to 3.7.3 and it would benefit AOSP. It's your call.

Sounds more like a local configuration issue or one in Android. I don't see a need for us to downgrade this and like you stated, "They stopped using ccache internally for their builds" so doesn't even sound like something you should be using in the first place then.