Page MenuHomeSolus

Update keepassx to 2.5.0

Authored by livingsilver94 on Oct 27 2019, 10:50 AM.



Changelog available here.

Test Plan

Successfully opened my database.

Diff Detail

R1543 keepassx
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

livingsilver94 requested review of this revision.Oct 27 2019, 10:50 AM

Isn't this a bit long for a summary ?


Why do you override the build type ?

Girtablulu requested changes to this revision.Oct 27 2019, 6:35 PM
Girtablulu added a subscriber: Girtablulu.

yea summarize this changelog before core is going to murder you :)

This revision now requires changes to proceed.Oct 27 2019, 6:35 PM
livingsilver94 edited the summary of this revision. (Show Details)Oct 28 2019, 10:28 AM
livingsilver94 added inline comments.

I didn't know Solus was defaulting to RelWithDebInfo ( Sorry, I'll revert that. Thanks.

Remove build type in favor of default RelWithDebInfo.

livingsilver94 marked an inline comment as done.Oct 28 2019, 10:36 AM
livingsilver94 added inline comments.Oct 28 2019, 1:45 PM

There's a menu entry that opens the offline doc. Of course with these file missing, keepassxc is showing an error. IMO this is ugly and we should keep the doc. Let me know.

JoshStrobl added inline comments.

Yea let's go ahead and keep it.

JoshStrobl requested changes to this revision.Nov 1 2019, 9:45 AM

Marking explicitly as request changes.

This revision now requires changes to proceed.Nov 1 2019, 9:45 AM

Add offline doc

livingsilver94 marked an inline comment as done.Nov 1 2019, 10:47 AM
JoshStrobl accepted this revision.Nov 1 2019, 10:49 AM

LGTM, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Nov 1 2019, 10:50 AM
This revision was automatically updated to reflect the committed changes.