Page MenuHomeSolus

Update keepassx to 2.5.0
ClosedPublic

Authored by livingsilver94 on Sun, Oct 27, 10:50 AM.

Details

Summary

Changelog available here.

Test Plan

Successfully opened my database.

Diff Detail

Repository
R1543 keepassx
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

livingsilver94 requested review of this revision.Sun, Oct 27, 10:50 AM

Isn't this a bit long for a summary ?

package.yml
31

Why do you override the build type ?

Girtablulu requested changes to this revision.Sun, Oct 27, 6:35 PM
Girtablulu added a subscriber: Girtablulu.

yea summarize this changelog before core is going to murder you :)

This revision now requires changes to proceed.Sun, Oct 27, 6:35 PM
livingsilver94 edited the summary of this revision. (Show Details)Mon, Oct 28, 10:28 AM
livingsilver94 added inline comments.
package.yml
31

I didn't know Solus was defaulting to RelWithDebInfo (https://github.com/getsolus/ypkg/blob/master/ypkg2/rc.yml). Sorry, I'll revert that. Thanks.

Remove build type in favor of default RelWithDebInfo.

livingsilver94 marked an inline comment as done.Mon, Oct 28, 10:36 AM
livingsilver94 added inline comments.Mon, Oct 28, 1:45 PM
package.yml
43

There's a menu entry that opens the offline doc. Of course with these file missing, keepassxc is showing an error. IMO this is ugly and we should keep the doc. Let me know.

JoshStrobl added inline comments.
package.yml
43

Yea let's go ahead and keep it.

JoshStrobl requested changes to this revision.Fri, Nov 1, 9:45 AM

Marking explicitly as request changes.

This revision now requires changes to proceed.Fri, Nov 1, 9:45 AM

Add offline doc

livingsilver94 marked an inline comment as done.Fri, Nov 1, 10:47 AM
JoshStrobl accepted this revision.Fri, Nov 1, 10:49 AM

LGTM, thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Nov 1, 10:50 AM
This revision was automatically updated to reflect the committed changes.