Page MenuHomeSolus

Update libvirt to 5.8.0
AbandonedPublic

Authored by livingsilver94 on Oct 25 2019, 3:59 PM.

Details

Summary

Changelog available here starting from version 4.9.0.
Fixes T8299, T7213.

Test Plan

Successfully launched a Solus VM using virt-manager.
sudo apparmor_status correctly detects profiles and processes associated to libvirtd and VMs running.

Diff Detail

Repository
R1891 libvirt
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

livingsilver94 created this revision.Oct 25 2019, 3:59 PM
livingsilver94 requested review of this revision.Oct 25 2019, 3:59 PM
livingsilver94 added a subscriber: DataDrake.
NOTE: Do not accept this patch before having patched aa-lsm-hook. @DataDrake knows.
livingsilver94 added inline comments.Oct 25 2019, 4:03 PM
pspec_x86_64.xml
487

How does this differ from 50-libvirt.rules?

DataDrake requested changes to this revision.Nov 14 2019, 7:51 PM
DataDrake added inline comments.
pspec_x86_64.xml
487

.keyrules is a custom format we added to polkit so that we don't need to use JS for configuration. It's comparatively much faster.

This revision now requires changes to proceed.Nov 14 2019, 7:51 PM

Restore 50-libvirt.keyrules. Now I know what it is

Hmm maybe I should make a deprecation PR for libvirt-docs?

DataDrake requested changes to this revision.Nov 18 2019, 5:22 AM
DataDrake added inline comments.
pspec_x86_64.xml
128

Maybe this should get patterned into -docs rather than deprecating the package.

504

These should probably be tmpfiles since /var/run -> /run which is a tmpfs

This revision now requires changes to proceed.Nov 18 2019, 5:22 AM
pspec_x86_64.xml
128

What exactly? All the /usr/share/doc/libvirt dir?

504

Only /var/run? Because for example, samba has more dirs specified. I am aware that /var/lib and var/log are not tmpfs, still they're listed in that file...

DataDrake added inline comments.Nov 18 2019, 7:58 PM
pspec_x86_64.xml
128

All of /usr/share/doc afaict is not needed to be installed local.

504

You can do the others, yeah. /var/run is just the one that will always get this package marked as broken.

Remove whitespace added by mistake

livingsilver94 marked 3 inline comments as done.Nov 18 2019, 11:01 PM
DataDrake accepted this revision.Nov 26 2019, 12:32 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Nov 26 2019, 12:32 AM

We're at v6.2.0. now...

DataDrake abandoned this revision.Apr 13 2020, 1:48 AM

Looks like 6.1.0 snuck in ahead of this. Sorry about that! Please do rebase your tmpfiles changes on another patch. I wouldn't want to lose them!

What about the apparmor patch too?