Page MenuHomeSolus

Update brave to 0.70.121
ClosedPublic

Authored by Jacalz on Oct 25 2019, 3:32 PM.

Details

Summary

Summarized Changelog:

  • Added the ability to opt-in to user private Brave ads for over 20 new regions.
  • Added the ability for inline Twitter tip button to be keyboard accessible.
  • Added "Save All Files" option to WebTorrent.
  • Added widget menu for New Tab Page elements.
  • Added dark theme support for New Tab Page settings menu.
  • Updated default search engine to DuckDuckGo for Germany, Australia, New Zealand, and Ireland.
  • Updated auto-contribute to use "up to" budgeting and to only contribute to verified content creators.
  • Updated monthly contributions to process recurring tips individually before attempting auto-contribution.
  • Updated alert icon in rewards panel and profile icons.
  • Updated New Tab Page to respect 24 hour clock for locales which use this clock by default.
  • Fixed incorrect message display on tip banner in certain cases.
  • Fixed global shields setting for "Block all cookies" not working.
  • Fixed resizing issues on brave://welcome page.
  • Fixed leaving sync chain not appearing on other devices and sync records not updating.
  • Upgraded Chromium to 78.0.3904.70.

Security:

  • The update to chromium 78.0.3904.70 brings a total of 37 secuirty updates.
  • The following CVEs where of High severity:
    • CVE-2019-13699
    • CVE-2019-13700
    • CVE-2019-13701
Test Plan
  • Browsed a couple websites to test that it works as expected.
  • Verified that widewine was fully working.

Diff Detail

Repository
R4107 brave
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Jacalz created this revision.Oct 25 2019, 3:32 PM
Jacalz requested review of this revision.Oct 25 2019, 3:32 PM
Jacalz added a project: Restricted Project.Oct 25 2019, 3:32 PM

I don't know how hard it is but I will appreciate it if you can remove unknown from About Brave given below.
Version 0.69.135 Chromium: 77.0.3865.120 (Official Build) unknown (64-bit)

He's using the deb, that's not in his control, and regardless that should be filed as a software issue not a comment on a patch...

JoshStrobl accepted this revision.Oct 25 2019, 3:53 PM

LGTM, thanks!

This revision is now accepted and ready to land.Oct 25 2019, 3:53 PM
This revision was automatically updated to reflect the committed changes.
Jacalz added a comment.EditedOct 25 2019, 5:00 PM

Sorry to take this further here, but I just want to get this out before you open a task @maverick1. I have already asked the brave devs about help on getting that fixed and it seems that nobody knows how to fix the issue. I haven’t been able to find any way to fix this. It doesn’t impact the users in any way so it doesn’t really need to be fixed...

Sorry to take this further here, but I just want to get this out before you open a task @maverick1. I have already asked the brave devs about help on getting that fixed and it seems that nobody knows how to fix the issue. I haven’t been able to find any way to fix this. It doesn’t impact the users in any way so it doesn’t really need to be fixed...

I wasn't gonna open a task. I just saw your patch so thought may be you could fix this. No worries, doesn't disturb the workflow!