Initial commit of ibus-mozc ( T317 )
I tested on KDE Plasma Desktop and GNOME Desktop.
Details
Details
- Reviewers
JoshStrobl DataDrake - Group Reviewers
Triage Team - Commits
- R4977:66879b8534e9: Initial working ibus-mozc
Installed and tested on KDE Plasma Desktop and GNOME3(Virtual Box)
Diff Detail
Diff Detail
- Repository
- R4977 ibus-mozc
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| package.yml | ||
|---|---|---|
| 10 | We're not using any of the WTL bits, this can be removed. | |
| 11 | This is only referenced in the installer, which we don't use. Not needed. | |
| 12 | This is only referenced in the installer (which we don't use) and the unicode files don't mention a specific Unicode DFS license. | |
| 13 | I didn't see any reference to Unlicense in the codebase, where is this from? | |
| 16 | Did you hand write your package.yml? We have a script to generate it: There's no other way you would've made this mistake, so seems like you need to correct all this and resubmit / update your diff: https://getsol.us/articles/packaging/packaging-practices/en/#generating-a-package-yml | |
| 21 | Eliminate the unnecessary new lines. | |
| 34 | All of your install commands should be combined like -Dm00644 or -Dm00755. Not to mention you should be using a loop over a list of files instead of line-by-line, file-by-file. This applies to all the images as well, so that needs to be corrected. | |
| 55 | Not needed. | |
Comment Actions
Fix package.yml to revision
- Rebased package.yml on yauto.py
- Eliminated empty new lines
- Replaced '-D -m 00xxx' to '-Dm00xxx'
- Used loop to install png files
- Deleted credits_en.html
Comment Actions
I considering about license. ( I wrote at T317#159801 )
We can see mozc's third party license at https://github.com/google/mozc/blob/master/src/data/installer/credits_en.html
'Okinawa dictionary' was licensed by Public License(Unlicense?) and 'WTL' was licensed by MS-PL.
I searched other distribution's mozc package and found they listed only licenses included in SPDX or show "BSD3-License and custom".
Therefore I listed licenses included in SPDX.
How should I change licenses' list ? ( I have no experience of treating such a package include many third party code. Would you give me advicese?)
Comment Actions
As explained in my review, there are items which are only referenced in the credits / installer which we do not use or aren't relevant to us. The "Public Domain" referenced for the Okinawa is strictly in Japanese and is not a license which is identified by SPDX, thus shouldn't be listed. There is no guarantee they actually mean an identified public domain or "unlicense" license.
Comment Actions
Delete unnecessary licenses
Based on the review, I think Apache-2.0 was needless too and delete it.
| package.yml | ||
|---|---|---|
| 26 | As mentioned in my previous review:
So your installation of all these libs needs to be corrected. | |
Comment Actions
Should I replace 'ibus-mozc' and 'mozc.xml' install commands with loops?
I think replacing them makes redundancy and needless, so I didn't replace them.
But if I should, I will replace.
Comment Actions
Fix all package install command by using loop
replaced install commands of 'ibus-mozc' and 'mozc.xml' with loop.