Details

Reviewers

JoshStrobl

Group Reviewers

Triage Team

Commits

R4487:59308e128986: Update yacreader to 9.6.2

Summary

YACReader

Fix some issues in magnifying glass when used in hdpi screens

YACReaderLibrary

New setting to close YACReaderLibrary to the system tray.
Option to hide current/next comic banner in the grid view.
Fix saving progress when reading in double page mode.
Fixes in Comic Vine integration.
Other fixes and stability improvements.

Signed-off-by: Algent Albrahimi <algent@protonmail.com>

Test Plan

Opened a Comic and created a new libary

Diff Detail

Repository

R4487 yacreader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

algent created this revision.Oct 22 2019, 6:56 PM

Herald added a reviewer: Triage Team. · View Herald TranscriptOct 22 2019, 6:56 PM

Fixed summary

Removed pkgconfig(glu) because libGLU.so.1 is not used.

The server and server service should be either disabled at configure time so we don't build them, or removed during the install phase (preferably the first, if the option is available). Its sole purpose is to allow serving comics to the iOS client, and this isn't something a "desktop" operating system should be doing.

This revision now requires changes to proceed.Oct 23 2019, 4:26 PM

Removing YACReaderLibraryServer

LGTM, thanks!

This revision is now accepted and ready to land.Oct 23 2019, 7:10 PM

Closed by commit R4487:59308e128986: Update yacreader to 9.6.2 (authored by algent, committed by JoshStrobl). · Explain WhyOct 23 2019, 7:11 PM

This revision was automatically updated to reflect the committed changes.

JoshStrobl added a commit: R4487:59308e128986: Update yacreader to 9.6.2.

		Path
M		abi_used_libs (2 lines)
A	M	files/0001-removing-yacreader-library-server.patch (21 lines)
M		package.yml (15 lines)
M		pspec_x86_64.xml (18 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	17899	3f9e65f		Oct 22 2019, 6:56 PM	★	★
Diff 2	17900	3f9e65f	Fixed summary	Oct 22 2019, 6:58 PM	★	★
Diff 3	17901	3f9e65f	Removed pkgconfig(glu) because libGLU.so.1 is not used.	Oct 22 2019, 7:17 PM	★	★
Diff 4	17933	3f9e65f	Removing YACReaderLibraryServer	Oct 23 2019, 6:59 PM	★	★
Diff 5	17934	3f9e65f	R4487:59308e1289863668e524770cf1c9bf35dc037594	Oct 23 2019, 7:11 PM	★	★

Update yacreader to 9.6.2
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 17934

abi_used_libs

files/0001-removing-yacreader-library-server.patch

package.yml

pspec_x86_64.xml

Update yacreader to 9.6.2ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17934

abi_used_libs

files/0001-removing-yacreader-library-server.patch

package.yml

pspec_x86_64.xml

Update yacreader to 9.6.2
ClosedPublic
Actions

Revision Contents
Changeset List